Re: [PATCH] add -s option to make -break-insert support dprintf

Eli Zaretskii
2013-05-11T07:29:08Z

> From: Hui Zhu <teawater@gmail.com>
> Date: Sat, 11 May 2013 10:37:56 +0800
> Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>, Hui Zhu <hui_zhu@mentor.com>,
> gdb-patches ml <gdb-patches@sourceware.org>, Marc Khouzam <marc.khouzam@ericsson.com>
>
> --- a/NEWS
> +++ b/NEWS
> @@ -60,6 +60,8 @@ show debug nios2
> ** The -trace-save MI command can optionally save trace buffer in Common
> Trace Format now.
>
> + ** The new command -dprintf-insert sets a dynamic printf breakpoint.
> +
> *** Changes in GDB 7.6

This part is OK.

> +If specified, @var{location}, can be one of:
> +
> +@itemize @bullet
> +@item function
> +@c @item +offset
> +@c @item -offset
> +@c @item linenum
> +@item filename:linenum
> +@item filename:function
> +@item *address
> +@end itemize

Each of "function", "filename", "linenum", and "address" above
should be in @var{}, because they do not stand for themselves.

> +If @var{location} cannot be parsed (for example if it
^
A comma is missing.

> +refers to unknown files or functions), create a pending
> +breakpoint. Without this flag, @value{GDBN} will report
^^
Two spaces between sentences.

> +@item -i @var{ignore-count}
> +Initialize the @var{ignore-count}.

"Set the ignore count of the breakpoint (@pxref{Conditions, ignore
count}) to @var{ignore-count}."

> +Note: this format is open to change.

Why do we need this note in the manual?

> +The corresponding @value{GDBN} commands are @samp{dprintf}.
^^^^^^^^^^^^
"command is"

Thanks.