From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8771 invoked by alias); 21 May 2013 05:44:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8761 invoked by uid 89); 21 May 2013 05:44:35 -0000 X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_HOSTKARMA_NO autolearn=no version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 05:44:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C51D82EE33; Tue, 21 May 2013 01:44:32 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3eSXRxp7ScVW; Tue, 21 May 2013 01:44:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5BF8B2E6A8; Tue, 21 May 2013 01:44:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D0FA9C376B; Tue, 21 May 2013 09:44:26 +0400 (RET) Date: Tue, 21 May 2013 05:44:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] Message-ID: <20130521054426.GA19975@adacore.com> References: <51941E85.8010104@redhat.com> <20130516053008.GA5555@adacore.com> <20130516054906.GB5555@adacore.com> <5194FE2A.7000205@redhat.com> <20130517051435.GC4017@adacore.com> <87ehd5r2qr.fsf@fleche.redhat.com> <20130520052818.GK4017@adacore.com> <87ehd1ogh9.fsf@fleche.redhat.com> <20130521054334.GV4017@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20130521054334.GV4017@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00756.txt.bz2 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 279 > Cool, thanks! Attached is what I checked in, after a round of testing on > x86_64-linux. > > gdb/ChangeLog: > > * ada-lang.c (old_renaming_is_invisible): Fix cleanup leak. > > Thanks again for pointing this cleanup leak out. Really attached, this time... -- Joel --5mCyUwZo2JvN/JJP Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Ada-Fix-cleanup-leak-in-ada-lang.c-old_renaming_is_i.patch" Content-length: 2053 >From aea9d783272e628dea85555ebebc0f3891fd5f77 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 21 May 2013 09:40:01 +0400 Subject: [PATCH] [Ada] Fix cleanup leak in ada-lang.c:old_renaming_is_invisible gdb/ChangeLog: * ada-lang.c (old_renaming_is_invisible): Fix cleanup leak. --- gdb/ChangeLog | 4 ++++ gdb/ada-lang.c | 16 ++++++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 19a4cd6..c48f7e7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2013-05-21 Joel Brobecker + + * ada-lang.c (old_renaming_is_invisible): Fix cleanup leak. + 2013-05-21 Hui Zhu * breakpoint.c (dprintf_breakpoint_ops): Remove its static. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index fa6db0f..b6d5e0b 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -4726,17 +4726,20 @@ static int old_renaming_is_invisible (const struct symbol *sym, const char *function_name) { char *scope; + struct cleanup *old_chain; if (SYMBOL_CLASS (sym) != LOC_TYPEDEF) return 0; scope = xget_renaming_scope (SYMBOL_TYPE (sym)); - - make_cleanup (xfree, scope); + old_chain = make_cleanup (xfree, scope); /* If the rename has been defined in a package, then it is visible. */ if (is_package_name (scope)) - return 0; + { + do_cleanups (old_chain); + return 0; + } /* Check that the rename is in the current function scope by checking that its name starts with SCOPE. */ @@ -4748,7 +4751,12 @@ old_renaming_is_invisible (const struct symbol *sym, const char *function_name) if (strncmp (function_name, "_ada_", 5) == 0) function_name += 5; - return (strncmp (function_name, scope, strlen (scope)) != 0); + { + int is_invisible = strncmp (function_name, scope, strlen (scope)) != 0; + + do_cleanups (old_chain); + return is_invisible; + } } /* Remove entries from SYMS that corresponds to a renaming entity that -- 1.7.10.4 --5mCyUwZo2JvN/JJP--