From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17350 invoked by alias); 17 May 2013 05:30:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17330 invoked by uid 89); 17 May 2013 05:30:54 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 05:30:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 82DA22EAA9; Fri, 17 May 2013 01:30:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ct50Tbibg9g2; Fri, 17 May 2013 01:30:50 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 748392E2F3; Fri, 17 May 2013 01:30:49 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A4855C25F1; Fri, 17 May 2013 09:30:42 +0400 (RET) Date: Fri, 17 May 2013 05:30:00 -0000 From: Joel Brobecker To: Thomas Schwinge Cc: Yue Lu , bug-hurd@gnu.org, gdb-patches@sourceware.org Subject: Re: [patch] for mig check in GDB's configure Message-ID: <20130517053042.GD4017@adacore.com> References: <8738u4sc19.fsf@kepler.schwinge.homeip.net> <87txmkxlu6.fsf@violet.siamics.net> <871u96mvy7.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <871u96mvy7.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg00664.txt.bz2 Hi Thomas and Yue, > After reviewing and testing it, I now checked in your patch (very minor > coding style and wording changes). Congratulations to your first > contribution! :-) > > 2013-05-16 Yue Lu > > * configure.ac: Ensure MIG is available when building for GNU Hurd > hosts. > * configure: Regenerate. I cannot remember if we said Yue had a copyright assignment on file, or not. I checked the file, and couldn't locate him. Can you clarify? This patch is small enough that it can be accepted without regardless; but if we do, I'd like to mark it as such in the ChangeLog entry (using "(tiny change)", as mentioned by the guide for GNU maintainers). Thank you! > > Index: configure.ac > =================================================================== > RCS file: /cvs/src/src/gdb/configure.ac,v > retrieving revision 1.203 > diff -u -p -r1.203 configure.ac > --- configure.ac 10 May 2013 16:10:40 -0000 1.203 > +++ configure.ac 16 May 2013 21:50:18 -0000 > @@ -486,8 +486,15 @@ AC_CHECK_TOOL(AR, ar) > AC_CHECK_TOOL(DLLTOOL, dlltool) > AC_CHECK_TOOL(WINDRES, windres) > > -# Needed for GNU/Hurd. > -AC_CHECK_TOOL(MIG, mig) > +case $host_os in > + gnu*) > + # Needed for GNU Hurd hosts. > + AC_CHECK_TOOL(MIG, mig) > + if test x"$MIG" = x; then > + AC_MSG_ERROR([MIG not found but required for $host hosts]) > + fi > + ;; > +esac > > # ---------------------- # > # Checks for libraries. # > Index: configure > =================================================================== > RCS file: /cvs/src/src/gdb/configure,v > retrieving revision 1.391 > diff -u -p -r1.391 configure > --- configure 10 May 2013 16:10:40 -0000 1.391 > +++ configure 16 May 2013 21:50:20 -0000 > [...] > > > Grüße, > Thomas -- Joel