From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101613-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16485 invoked by alias); 16 May 2013 14:04:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16463 invoked by uid 89); 16 May 2013 14:04:48 -0000
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.1
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 14:04:47 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r4GE4gi3009926;	Thu, 16 May 2013 16:04:42 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r4GE4gfX006357;	Thu, 16 May 2013 16:04:42 +0200 (CEST)
Date: Thu, 16 May 2013 14:04:00 -0000
Message-Id: <201305161404.r4GE4gfX006357@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pavel.v.chupin@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to:	<CANwJu1-W4XUF1mfZnXOa1UgcAP+d8nksJA8ke1FUtBQC2uH+Jw@mail.gmail.com>	(message from Pavel Chupin on Thu, 16 May 2013 10:47:14 +0400)
Subject: Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability
References: <CANwJu1-LGhEaeA3Mmi37UkLZOAqEFpzFpKaKzL3MVA2WORdR7Q@mail.gmail.com>	<CANwJu18MP86hi3etqskPSR3Pt6tPEZCSndzW2No_9ZHEig0AHQ@mail.gmail.com>	<201305061230.r46CU0P4006086@glazunov.sibelius.xs4all.nl>	<CANwJu1_HerKDCXB4gWAXMQY5TBe++X1A2bFSPcj+xg+MGnYQtA@mail.gmail.com>	<87a9nx5qv9.fsf@fleche.redhat.com>	<201305141923.r4EJNvUE017192@glazunov.sibelius.xs4all.nl> <CANwJu1-W4XUF1mfZnXOa1UgcAP+d8nksJA8ke1FUtBQC2uH+Jw@mail.gmail.com>
X-SW-Source: 2013-05/txt/msg00619.txt.bz2

> Date: Thu, 16 May 2013 10:47:14 +0400
> From: Pavel Chupin <pavel.v.chupin@gmail.com>
> 
> On Tue, May 14, 2013 at 11:23 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> From: Tom Tromey <tromey@redhat.com>
> >> Date: Tue, 14 May 2013 13:00:10 -0600
> >>
> >> Mark> The fix isn't quite right.  OpenBSD for example has <dlfcn.h> but no
> >> Mark> libdl; dlopen(3) and friends live in libc.
> >>
> >> Pavel> Hi Mark,
> >> Pavel> Thanks for your comments. Please see new patch attached.
> >>
> >> Pavel> -    LIBS="-ldl $LIBS"
> >> Pavel> +    AC_CHECK_LIB(dl, dlopen)
> >>
> >> I think it is probably better to use AC_SEARCH_LIBS.
> >
> > That's indeed what the autoconf manual suggests.
> 
> Please see attached.
> 
> ChangeLog entry didn't change:
> 2013-05-16  Pavel Chupin  <pavel.v.chupin@intel.com>
> 
>         Replace hardcoded -ldl with check for availability
>         * acinclude.m4: Add check for dlopen in libdl.
>         * configure.ac: Ditto.
>         * configure: Regenerate.
> 
> Is it OK for trunk?

Fine with me.