From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22908 invoked by alias); 16 May 2013 05:30:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22897 invoked by uid 89); 16 May 2013 05:30:18 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 05:30:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 238EE2ECF0; Thu, 16 May 2013 01:30:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Dx1IRnfcO2aN; Thu, 16 May 2013 01:30:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 827192EB92; Thu, 16 May 2013 01:30:15 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 91827C16D0; Thu, 16 May 2013 09:30:09 +0400 (RET) Date: Thu, 16 May 2013 05:30:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: Sergio Durigan Junior , "gdb-patches@sourceware.org ml" Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] Message-ID: <20130516053008.GA5555@adacore.com> References: <51895A2F.8000504@redhat.com> <5191340B.60100@redhat.com> <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51941E85.8010104@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg00567.txt.bz2 > > (gdb) complete break filesy > > break filesym > > break filesym.c > > Is that necessarily "better" than testing what a user would actually > type? I don't know. gdb.base/completion.exp uses both forms. I haven't verified yet that the issue you fixed is the same as the issue I noticed, and put aside for later. But my initial investigation at the time showed that the problem did not appear when using the "complete" command, only when using the interactive form via the "tab" key. > >Also, ISTR "send_gdb" is deprecated, and one should use > >"gdb_test_multiple" instead. WDYT? > > Is send_gdb deprecated or gdb_expect? Or is their direct use discouraged? My take on this is that it is very highly discouraged, at least for gdb_expect, and should only be used when none of the standard gdb_test et al routines can do the job. The reason behind it is that using gdb_expect directly, you are missing out on the standard processing of various known conditions (internal errors, timeouts, etc). -- Joel