Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it

Yao Qi
2013-05-15T14:17:42Z

Luis,
I went through the patch, and didn't see something wrong. Some nits on
changelog.

On 05/15/2013 07:25 PM, Luis Machado wrote:
>
> 2013-05-15 Luis Machado<lgustavo@codesourcery.com>
>
> * linux-low.c: Move definition checks upwards for PT_TEXT_ADDR,
> PT_DATA_ADDR and PT_TEXT_END_ADDR. Update comments.
^^ Two spaces after ".".

> (linux_read_offsets): Remove PT_TEXT_ADDR, PT_DATA_ADDR and
> PT_TEXT_END_ADDR guards. Update comments.
^ Likewise.

> (linux_target_op) <read_offsets): Conditionally define to
^ ")" -> ">"

> linux_read_offsets if the target is UCLIBC and if it defines
> PT_TEXT_ADDR, PT_DATA_ADDR and PT_TEXT_END_ADDR.

--
Yao (é½å°§)