From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11036 invoked by alias); 13 May 2013 13:19:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11023 invoked by uid 89); 13 May 2013 13:19:31 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_PASS,TW_HW autolearn=ham version=3.3.1 Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 13:19:30 +0000 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 May 2013 14:15:35 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 13 May 2013 14:15:33 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 99BE417D8017 for ; Mon, 13 May 2013 14:20:32 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4DDJFfH41484306 for ; Mon, 13 May 2013 13:19:15 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4DDJNVM030009 for ; Mon, 13 May 2013 07:19:24 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id r4DDJKnN029814; Mon, 13 May 2013 07:19:21 -0600 Message-Id: <201305131319.r4DDJKnN029814@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 13 May 2013 15:19:20 +0200 Subject: Re: [PATCH] Fix hardware watchpoints on PowerPC servers To: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado) Date: Mon, 13 May 2013 13:19:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1368426484-32623-1-git-send-email-emachado@linux.vnet.ibm.com> from "Edjunior Barbosa Machado" at May 13, 2013 03:28:04 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13051313-8372-0000-0000-000005FF9C96 X-SW-Source: 2013-05/txt/msg00432.txt.bz2 Edjunior Machado wrote: > initially developed only for bookE (embedded processors), the new ptrace > interface is now available for Power server processors too [1]. > > This patch fixes the insertion of hardware watchpoints on Power servers > using this new interface available on kernel 3.7 and newer (currently, the > region should be aligned to 8 bytes, which is also the max length). It reduces > the number of unexpected failures in gdb testsuite in 40 failures (ppc64 > running kernel 3.8). So the kernel now reports it supports PPC_DEBUG_FEATURE_DATA_BP_RANGE, but then rejects any attempt to set a range BP of more than 8 bytes? And there's no way to check for this ahead of time except for checking the BookE hwcaps bits? That seems unfortunate ... But I guess if that's the way the kernel interface is now, we'll have to add that check. > * ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): Check if the > region is ok for a hardware watchpoint using the new ptrace interface > on Power servers. This is OK. As noted by Luis, it would be good to rename the "booke" terminology, maybe using something like "have_ptrace_hwdebug" instead of have_ptrace_booke_interface. But that should be a separate patch. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com