From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2000 invoked by alias); 8 May 2013 06:15:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1986 invoked by uid 89); 8 May 2013 06:15:50 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 06:15:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 261572E904; Wed, 8 May 2013 02:15:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id I+v9mYzF4M4Q; Wed, 8 May 2013 02:15:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6AB332E72E; Wed, 8 May 2013 02:15:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 14F56C1729; Wed, 8 May 2013 10:15:42 +0400 (RET) Date: Wed, 08 May 2013 06:15:00 -0000 From: Joel Brobecker To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [commit] reimplement AIX shared-lib support (v3) Message-ID: <20130508061541.GA9160@adacore.com> References: <1367850045-26717-1-git-send-email-brobecker@adacore.com> <5189057B.5070909@codesourcery.com> <874neex4e2.fsf@fleche.redhat.com> <51890CF4.5090709@codesourcery.com> <20130507142812.GQ5278@adacore.com> <51891375.2020105@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <51891375.2020105@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00268.txt.bz2 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1014 > Ah, here it is. > > The failure seems to be due to solib_aix_free_library_list only > being defined if HAVE_LIBEXPAT is defined, but it is being used in > solib_aix_normal_stop_observer regardless of HAVE_LIBEXPAT being > defined or not. > > I was missing libexpat in my system, so that's why i was seeing this > failure. Looks like it is a real GDB bug. Ah, you are very right, and if I understand things correctly, you'd even have a link failure if you compiled past the warning. Fixed thusly: gdb/ChangeLog: * solib-aix.c (solib_aix_free_library_list): New function for the case where HAVE_LIBEXPAT is not defined. Although, now that I have checked the change in, I am wondering whether I could simply move the function out of the #if defined (and whether that might make sense or not)... The main advantage is that we're not duplicating the function's prototype. Not much time today, but I will keep that for tomorrow. In the meantime, I wanted the problem to be fixed ASAP. -- Joel --T4sUOijqQbZv57TR Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Dummy-implementation-of-solib_aix_free_library_list-.patch" Content-length: 1274 >From 786ba18d6cc536a7ccf2ac18b8e81b65758939f6 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 8 May 2013 10:02:45 +0400 Subject: [PATCH] Dummy implementation of solib_aix_free_library_list if libexpat missing. gdb/ChangeLog: * solib-aix.c (solib_aix_free_library_list): New function for the case where HAVE_LIBEXPAT is not defined. --- gdb/ChangeLog | 5 +++++ gdb/solib-aix.c | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2506ce5..f830db6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-05-08 Joel Brobecker + + * solib-aix.c (solib_aix_free_library_list): New function + for the case where HAVE_LIBEXPAT is not defined. + 2013-05-07 Sergio Durigan Junior PR breakpoints/15413: diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c index d930769..9fa5de9 100644 --- a/gdb/solib-aix.c +++ b/gdb/solib-aix.c @@ -141,6 +141,13 @@ solib_aix_parse_libraries (const char *library) return NULL; } +/* Dummy implementation if XML support is not compiled in. */ + +static void +solib_aix_free_library_list (void *p) +{ +} + #else /* HAVE_LIBEXPAT */ #include "xml-support.h" -- 1.7.10.4 --T4sUOijqQbZv57TR--