From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24358 invoked by alias); 8 May 2013 05:54:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24345 invoked by uid 89); 8 May 2013 05:54:59 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 05:54:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 599F82E904; Wed, 8 May 2013 01:54:57 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 80LLOVV62IjC; Wed, 8 May 2013 01:54:57 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BD2562E3BB; Wed, 8 May 2013 01:54:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3C5B9C1729; Wed, 8 May 2013 09:54:51 +0400 (RET) Date: Wed, 08 May 2013 05:54:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH Message-ID: <20130508055451.GC11853@adacore.com> References: <20130501165750.GA453@host2.jankratochvil.net> <87obcoyot3.fsf@fleche.redhat.com> <20130507062305.GH5278@adacore.com> <87ip2uvonz.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ip2uvonz.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg00267.txt.bz2 > Joel> Should we consider changing it into an internal_warning? > > I think that is fine as long as it still makes tests fail. FWIW, agreed. I saw Jan's message that some tests did not fail, but that is a test issue, IMO. In my case, the warning would have caused a failure as well. -- Joel