From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6499 invoked by alias); 7 May 2013 13:07:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6490 invoked by uid 89); 7 May 2013 13:07:46 -0000 X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail.openrapids.net (HELO blackscsi.openrapids.net) (64.15.138.104) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 07 May 2013 13:07:45 +0000 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id 8822E141863; Tue, 7 May 2013 09:07:42 -0400 (EDT) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ecjC+vF2XtE; Tue, 7 May 2013 09:07:41 -0400 (EDT) Received: by blackscsi.openrapids.net (Postfix, from userid 1003) id 7527E141868; Tue, 7 May 2013 09:07:41 -0400 (EDT) Date: Tue, 07 May 2013 13:07:00 -0000 From: Mathieu Desnoyers To: Hui Zhu Cc: Yao Qi , gdb-patches@sourceware.org, Pedro Alves , lttng-dev Subject: Re: [PATCH 3/5] Read CTF by the ctf target Message-ID: <20130507130741.GE4186@Krystal> References: <1361931459-3953-1-git-send-email-yao@codesourcery.com> <1361931459-3953-4-git-send-email-yao@codesourcery.com> <512F9182.3080104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Editor: vi User-Agent: Mutt/1.5.18 (2008-05-17) X-SW-Source: 2013-05/txt/msg00211.txt.bz2 * Hui Zhu (teawater@gmail.com) wrote: > On Fri, Mar 1, 2013 at 1:18 AM, Pedro Alves wrote: > > (not a complete review) > > > > On 02/27/2013 02:17 AM, Yao Qi wrote: > > > >> +if test "x$with_babeltrace" != "xno"; then > >> + saved_CFLAGS="$CFLAGS" > >> + CFLAGS="$CFLAGS $btinc" > >> + AC_MSG_CHECKING([for babeltrace]) > >> + AC_TRY_COMPILE([ > >> +#include > >> +#include > >> +#include > > > > We know from previous patches that the latest released > > babeltrace breaks gdb, due to the lookup_enum function. Does > > this catch that? I see namespacing fixes going into > > babeltrace as recently as last 15th. Do we know if > > babeltrace's API is more or less done and close to a release? > > Hi Mathieu, > > Could you help us with this question? We did the 1.1.0 release specifically for namespace fixes on March 23rd. commit c99b1910bea848e8f0ae5641bb63b8f4f84f3ec0 Author: Mathieu Desnoyers Date: Sat Mar 23 13:34:22 2013 -0400 Version 1.1.0 Signed-off-by: Mathieu Desnoyers Thanks, Mathieu > > Thanks, > Hui > > > > >> + ],[], > >> + [AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBBABELTRACE, 1, [Define if libbabeltrace is available])], > >> + [AC_MSG_RESULT([no]); btlibs= ; btinc= ]) > >> + CFLAGS="$saved_CFLAGS" > >> +fi > >> + > >> +# Flags needed for UST > > > > babeltrace > > > >> +AC_SUBST(btlibs) > >> +AC_SUBST(btinc) > >> + > > > > -- > > Pedro Alves > > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com