Re: [ANNOUNCEMENT] GDB 7.6 released!

Eli Zaretskii
2013-04-28T16:24:14Z

> Date: Sun, 28 Apr 2013 11:38:05 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > > The offending incomplete type is 'enum errors'.
> >
> > Any reason not to include exceptions.h in utils.h, to avoid these
> > warnings?
>
> No objection from me. We'd then be able to remove the partial
> declaration of that enum.

OK, will install such a change (if, when the dust settles on the issue
you raise below, we decide to leave the function).

> I am wondering why we are not seeing this on other platforms...

Probably because I was using a _really_ old compiler (3.4.2) on the
machine where I saw this.

> utils.c:throw_perror_with_name doesn't appear to be used anywhere except
> in utils.c:perror_with_name, which is nothing more than a wrapper where
> errcode is set to GENERIC_ERROR. I am wondering if we want to keep that
> function around, or either make the function static, or inline its code
> in perror_with_name...
>
> I'd probably investigate why and when the function was introduced
> before making a decision, but I am running out of time for today...

It's not urgent.

Thanks.