From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8206 invoked by alias); 30 Apr 2013 07:30:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8197 invoked by uid 89); 30 Apr 2013 07:30:38 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Apr 2013 07:30:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1E5971C6418; Tue, 30 Apr 2013 03:30:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SepctT5Ldou6; Tue, 30 Apr 2013 03:30:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ADE4C1C619B; Tue, 30 Apr 2013 03:30:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 12398C2AFB; Tue, 30 Apr 2013 00:30:31 -0700 (PDT) Date: Tue, 30 Apr 2013 11:53:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Maxime Coste , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame Message-ID: <20130430073030.GB3525@adacore.com> References: <1367002961-12311-1-git-send-email-frrrwww@gmail.com> <1367002961-12311-2-git-send-email-frrrwww@gmail.com> <87r4htxeth.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r4htxeth.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00892.txt.bz2 > Maxime> select_frame calls specify if the frame is selected due to > Maxime> a breakpoint/signal (REASON_STOP), a user command (REASON_USER) > Maxime> or just as an implementation detail (REASON_IMPL_DETAIL) which > Maxime> should restore the previous frame once finished. > > I don't mind this approach but I would like to hear from other > maintainers. I wasn't super fond when I saw this yesterday, TBH, particuarly after seeing how it's used in the patch. But I haven't really had time to think this over to see if I can propose something else. So do not block the patch on my account. -- Joel