From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25801 invoked by alias); 26 Apr 2013 11:54:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25788 invoked by uid 89); 26 Apr 2013 11:54:35 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 11:54:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5EC132ED90; Fri, 26 Apr 2013 07:54:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gyL5UFQtn-U8; Fri, 26 Apr 2013 07:54:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C15B92E814; Fri, 26 Apr 2013 07:54:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 162A9C70BD; Fri, 26 Apr 2013 04:54:27 -0700 (PDT) Date: Fri, 26 Apr 2013 19:02:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org, thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCH,HURD] Fix reading core Message-ID: <20130426115426.GS3525@adacore.com> References: <20130211020109.GK5926@type.youpi.perso.aquilenet.fr> <20130409234117.GC24389@adacore.com> <20130426111926.GX5825@type.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130426111926.GX5825@type.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-04/txt/msg00811.txt.bz2 > > > * gdb/i386gnu-nat.c (CREG_OFFSET): New macro. > > > (creg_offset): New array. > > > (CREG_ADDR): Use creg_offset instead of reg_offset. > > > > Did anyone review this? I don't know GNU/Hurd, but the patch looks > > very plausible. > > > > Do you have write access to the GDB repository? > > I don't. > > > If not, do you have copyright assignment papers on file? > > It's on file now. OK - if you have other patches in the pipeline, let's give you write access to the repository as soon as this patch is approved. I am not clear whether I should re-review, or let Thomas do it. Thank you, -- Joel