From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13926 invoked by alias); 24 Apr 2013 15:28:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13916 invoked by uid 89); 24 Apr 2013 15:28:30 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 15:28:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OFSRjH027937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Apr 2013 11:28:27 -0400 Received: from host2.jankratochvil.net (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3OFSNUp008768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Apr 2013 11:28:26 -0400 Date: Wed, 24 Apr 2013 20:35:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: RFC: close-on-exec internal file descriptors Message-ID: <20130424152823.GA7683@host2.jankratochvil.net> References: <874njjs1aa.fsf@fleche.redhat.com> <5175DF3E.10800@codesourcery.com> <871ua1qmc3.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871ua1qmc3.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-04/txt/msg00746.txt.bz2 On Tue, 23 Apr 2013 17:49:00 +0200, Tom Tromey wrote: > 2013-04-23 Tom Tromey > > * common/filestuff.c: Check USE_WIN32API before including > sys/socket.h. > (HAVE_F_GETFD): New define. > (mark_cloexec): Check HAVE_F_GETFD. > (gdb_open_cloexec): Change 'mode' to unsigned long. > (gdb_socketpair_cloexec): Check HAVE_SOCKETPAIR. > (gdb_pipe_cloexec): Check HAVE_PIPE. > * common/filestuff.h (gdb_open_cloexec): Change 'mode' to unsigned > long. Just confirming it fixed the MinGW problem for me for both 32 and 64 bits. Thanks, Jan