Re: [PATCH 4/8] Prepare linux_find_memory_regions_full & co. for move

Aleksandar Ristovski
2013-04-16T15:44:05Z

On 13-04-14 10:15 AM, Jan Kratochvil wrote:
> On Tue, 09 Apr 2013 17:27:41 +0200, Aleksandar Ristovski wrote:
> [...]
>> --- a/gdb/target.c
>> +++ b/gdb/target.c
>> @@ -3476,55 +3476,67 @@ target_fileio_close_cleanup (void *opaque)
>> target_fileio_close (fd, &target_errno);
>> }
>>
>> +/* Helper for target_fileio_read_alloc_1 to make it interruptible. */
>
> Here should be added (reason: so that one can easily find all the
> read_alloc_pread_ftype instances):
>
> static read_alloc_pread_ftype target_fileio_read_alloc_1_pread;
>
> (And move the read_alloc_pread_ftype definition above.)

Ok.

>> +typedef int (read_alloc_pread_ftype) (int handle, gdb_byte *read_buf, int len,
>> + ULONGEST offset, int *target_errno);
>
> Use tabs.

Ok.

>
>

...

>
>
> Here could be (so that one can easily find all the read_stralloc_func_ftype
> instances):
>
> static read_stralloc_func_ftype target_fileio_read_alloc_1;
>
> (And move the read_stralloc_func_ftype definition above.)

Ok.

Thanks,

Aleksandar