From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6989 invoked by alias); 11 Apr 2013 23:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6948 invoked by uid 89); 11 Apr 2013 23:02:10 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 23:02:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN28nw002318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Apr 2013 19:02:09 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3BN275v017535 for ; Thu, 11 Apr 2013 19:02:08 -0400 Subject: [PATCH 26/26] -Wpointer-sign: record.c. To: gdb-patches@sourceware.org From: Pedro Alves Date: Fri, 12 Apr 2013 10:39:00 -0000 Message-ID: <20130411230207.16791.4445.stgit@brno.lan> In-Reply-To: <20130411225847.16791.29283.stgit@brno.lan> References: <20130411225847.16791.29283.stgit@brno.lan> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SW-Source: 2013-04/txt/msg00365.txt.bz2 ../../src/gdb/record.c: In function ‘set_record_insn_history_size’: ../../src/gdb/record.c:670:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/record.c: In function ‘set_record_call_history_size’: ../../src/gdb/record.c:682:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ Here's the obvious fix. gdb/ 2013-04-11 Pedro Alves * record.c (validate_history_size): Make parameter 'setting' unsigned. --- gdb/record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/record.c b/gdb/record.c index 0a7f0a1..76d9fd2 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -643,7 +643,7 @@ cmd_record_call_history (char *arg, int from_tty) is the real setting the command allows changing. */ static void -validate_history_size (unsigned int *command_var, int *setting) +validate_history_size (unsigned int *command_var, unsigned int *setting) { if (*command_var != UINT_MAX && *command_var > INT_MAX) {