From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6279 invoked by alias); 11 Apr 2013 23:02:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6251 invoked by uid 89); 11 Apr 2013 23:02:03 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 23:02:03 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN21lc002286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Apr 2013 19:02:02 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN20HJ030030 for ; Thu, 11 Apr 2013 19:02:01 -0400 Subject: [PATCH 25/26] -Wpointer-sign: ctf.c. To: gdb-patches@sourceware.org From: Pedro Alves Date: Fri, 12 Apr 2013 10:18:00 -0000 Message-ID: <20130411230200.16791.97356.stgit@brno.lan> In-Reply-To: <20130411225847.16791.29283.stgit@brno.lan> References: <20130411225847.16791.29283.stgit@brno.lan> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00364.txt.bz2 ctf_save_write's second parameter is gdb_byte *, and all these arguments are 'char *'. Since this function is ultimately just writing host bytes to a local file with fwrite, an alternative would be to change ctf_save_write to take a 'void *' instead of 'gdb_byte *', thus removing the need for any cast (we have more calls with casts than without). gdb/ 2013-04-11 Pedro Alves * ctf.c (ctf_write_uploaded_tsv, ctf_write_uploaded_tp): Add casts to 'gdb_byte *'. --- gdb/ctf.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/gdb/ctf.c b/gdb/ctf.c index 0985784..ce0a318 100644 --- a/gdb/ctf.c +++ b/gdb/ctf.c @@ -528,7 +528,8 @@ ctf_write_uploaded_tsv (struct trace_file_writer *self, /* name */ if (tsv->name != NULL) - ctf_save_write (&writer->tcs, tsv->name, strlen (tsv->name)); + ctf_save_write (&writer->tcs, (gdb_byte *) tsv->name, + strlen (tsv->name)); ctf_save_write (&writer->tcs, &zero, 1); } @@ -580,30 +581,30 @@ ctf_write_uploaded_tp (struct trace_file_writer *self, /* condition */ if (tp->cond != NULL) - ctf_save_write (&writer->tcs, tp->cond, strlen (tp->cond)); + ctf_save_write (&writer->tcs, (gdb_byte *) tp->cond, strlen (tp->cond)); ctf_save_write (&writer->tcs, &zero, 1); /* actions */ u32 = VEC_length (char_ptr, tp->actions); ctf_save_align_write (&writer->tcs, (gdb_byte *) &u32, 4, 4); for (a = 0; VEC_iterate (char_ptr, tp->actions, a, act); ++a) - ctf_save_write (&writer->tcs, act, strlen (act) + 1); + ctf_save_write (&writer->tcs, (gdb_byte *) act, strlen (act) + 1); /* step_actions */ u32 = VEC_length (char_ptr, tp->step_actions); ctf_save_align_write (&writer->tcs, (gdb_byte *) &u32, 4, 4); for (a = 0; VEC_iterate (char_ptr, tp->step_actions, a, act); ++a) - ctf_save_write (&writer->tcs, act, strlen (act) + 1); + ctf_save_write (&writer->tcs, (gdb_byte *) act, strlen (act) + 1); /* at_string */ if (tp->at_string != NULL) - ctf_save_write (&writer->tcs, tp->at_string, + ctf_save_write (&writer->tcs, (gdb_byte *) tp->at_string, strlen (tp->at_string)); ctf_save_write (&writer->tcs, &zero, 1); /* cond_string */ if (tp->cond_string != NULL) - ctf_save_write (&writer->tcs, tp->cond_string, + ctf_save_write (&writer->tcs, (gdb_byte *) tp->cond_string, strlen (tp->cond_string)); ctf_save_write (&writer->tcs, &zero, 1); @@ -611,7 +612,7 @@ ctf_write_uploaded_tp (struct trace_file_writer *self, u32 = VEC_length (char_ptr, tp->cmd_strings); ctf_save_align_write (&writer->tcs, (gdb_byte *) &u32, 4, 4); for (a = 0; VEC_iterate (char_ptr, tp->cmd_strings, a, act); ++a) - ctf_save_write (&writer->tcs, act, strlen (act) + 1); + ctf_save_write (&writer->tcs, (gdb_byte *) act, strlen (act) + 1); }