From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1868 invoked by alias); 11 Apr 2013 23:01:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1846 invoked by uid 89); 11 Apr 2013 23:01:19 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 23:01:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN1HDt029874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Apr 2013 19:01:17 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN1GVX025482 for ; Thu, 11 Apr 2013 19:01:16 -0400 Subject: [PATCH 19/26] -Wpointer-sign: coff-pe-read.c: treat strings in PE/COFF data as char *. To: gdb-patches@sourceware.org From: Pedro Alves Date: Fri, 12 Apr 2013 08:58:00 -0000 Message-ID: <20130411230115.16791.47488.stgit@brno.lan> In-Reply-To: <20130411225847.16791.29283.stgit@brno.lan> References: <20130411225847.16791.29283.stgit@brno.lan> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00358.txt.bz2 A couple places take a pointer to the middle of some raw section buffer and treat them as strings. Add casts to char * as appropriate, fixing -Wpointer-sign warnings. gdb/ 2013-04-11 Pedro Alves * coff-pe-read.c (read_pe_exported_syms): Handle strings as char. --- gdb/coff-pe-read.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c index 8961c78..91ee3f6 100644 --- a/gdb/coff-pe-read.c +++ b/gdb/coff-pe-read.c @@ -505,7 +505,7 @@ read_pe_exported_syms (struct objfile *objfile) exp_funcbase = pe_as32 (expdata + 28); /* Use internal dll name instead of full pathname. */ - dll_name = pe_as32 (expdata + 12) + erva; + dll_name = (char *) (pe_as32 (expdata + 12) + erva); pe_sections_info.nb_sections = otherix; pe_sections_info.sections = section_data; @@ -579,9 +579,10 @@ read_pe_exported_syms (struct objfile *objfile) if ((func_rva >= section_data[sectix].rva_start) && (func_rva < section_data[sectix].rva_end)) { + char *sym_name = (char *) (erva + name_rva); + section_found = 1; - add_pe_exported_sym (erva + name_rva, - func_rva, ordinal, + add_pe_exported_sym (sym_name, func_rva, ordinal, section_data + sectix, dll_name, objfile); ++nbnormal; break;