From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31481 invoked by alias); 11 Apr 2013 23:00:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31387 invoked by uid 89); 11 Apr 2013 23:00:49 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 23:00:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN0lvG032058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Apr 2013 19:00:47 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3BN0krm025321 for ; Thu, 11 Apr 2013 19:00:46 -0400 Subject: [PATCH 15/26] gdb_byte for binary buffer, char for string: common/agent.c. To: gdb-patches@sourceware.org From: Pedro Alves Date: Thu, 11 Apr 2013 23:23:00 -0000 Message-ID: <20130411230045.16791.88288.stgit@brno.lan> In-Reply-To: <20130411225847.16791.29283.stgit@brno.lan> References: <20130411225847.16791.29283.stgit@brno.lan> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00354.txt.bz2 Similarly to the remote code, agent commands are mostly ascii. Cast to gdb_byte when treating the command buffer as raw memory bytes. 2013-04-11 Pedro Alves * common/agent.c (agent_run_command): Add cast to gdb_byte *. --- gdb/common/agent.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/common/agent.c b/gdb/common/agent.c index 632310d..f7bedc2 100644 --- a/gdb/common/agent.c +++ b/gdb/common/agent.c @@ -218,7 +218,8 @@ agent_run_command (int pid, const char *cmd, int len) int ret = write_inferior_memory (ipa_sym_addrs.addr_cmd_buf, (const unsigned char *) cmd, len); #else - int ret = target_write_memory (ipa_sym_addrs.addr_cmd_buf, cmd, len); + int ret = target_write_memory (ipa_sym_addrs.addr_cmd_buf, + (gdb_byte *) cmd, len); #endif if (ret != 0)