Re: [PATCH 00/26] Make GDB -Wpointer-sign clean.

Tom Tromey
2013-04-12T15:45:50Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> This makes GDB -Wpointer-sign clean on x86_64 GNU/Linux,
Pedro> --enable-targets=all. Once this is in, and perhaps a couple hosts
Pedro> more are clean too (mingw and i386 GNU/Linux at least; haven't tried
Pedro> those), I'll propose enabling the switch by default.

Thanks. I think the sooner it is enabled, the better.
Enabling reduces the chances for bit-rot, and fixing up any build
problems looks very easy.

Pedro> I'm hoping this sort of split makes review easy and allows quick
Pedro> turnaround as consequence.

I skimmed through all the patches and read ones more deeply where I know
the code well. It all looks good to me.

thanks,
Tom