Re: [patch 5/6] Move linux_find_memory_regions_full & co.

Jan Kratochvil
2013-03-28T20:14:05Z

On Wed, 27 Mar 2013 21:17:12 +0100, Aleksandar Ristovski wrote:
> Moves should now be clean, without mods.
[...]
> @@ -3560,6 +3495,10 @@ target_fileio_read_alloc_1 (const char *filename,
> make_cleanup (free_current_contents, &memory_to_free);
> retval = read_alloc (buf_p, fd, target_fileio_read_alloc_1_pread, padding,
> &memory_to_free);
> + if (retval >= 0)
> + /* Returned allocated memory is interesting for the caller. */
> + memory_to_free = NULL;

The formatting according to GDB specific style in gdb/doc/gdbint.texinfo:

if (retval >= 0)
{
/* Returned allocated memory is interesting for the caller. */
memory_to_free = NULL;
}

> +
> do_cleanups (close_cleanup);
> return retval;
> }

This part should have been in the previous patch. No need to repost but
please rearrange it during the final check-in.

Jan