From e2463d80dc42cfef1fb233d19cdd1dfc752c8236 Mon Sep 17 00:00:00 2001 From: Aleksandar Ristovski Date: Wed, 27 Mar 2013 16:06:26 -0400 Subject: [PATCH 8/8] Tests for validate symbol file using build-id. * gdb.base/solib-mismatch-lib.c: New file. * gdb.base/solib-mismatch-libmod.c: New file. * gdb.base/solib-mismatch.c: New file. * gdb.base/solib-mismatch.exp: New file. --- gdb/testsuite/gdb.base/solib-mismatch-lib.c | 29 +++++ gdb/testsuite/gdb.base/solib-mismatch-libmod.c | 29 +++++ gdb/testsuite/gdb.base/solib-mismatch.c | 68 ++++++++++ gdb/testsuite/gdb.base/solib-mismatch.exp | 157 ++++++++++++++++++++++++ 4 files changed, 283 insertions(+) create mode 100644 gdb/testsuite/gdb.base/solib-mismatch-lib.c create mode 100644 gdb/testsuite/gdb.base/solib-mismatch-libmod.c create mode 100644 gdb/testsuite/gdb.base/solib-mismatch.c create mode 100644 gdb/testsuite/gdb.base/solib-mismatch.exp diff --git a/gdb/testsuite/gdb.base/solib-mismatch-lib.c b/gdb/testsuite/gdb.base/solib-mismatch-lib.c new file mode 100644 index 0000000..19f1545 --- /dev/null +++ b/gdb/testsuite/gdb.base/solib-mismatch-lib.c @@ -0,0 +1,29 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2013 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + + +int _bar = 42; + +int bar(void) +{ + return _bar + 21; +} + +int foo(void) +{ + return _bar; +} diff --git a/gdb/testsuite/gdb.base/solib-mismatch-libmod.c b/gdb/testsuite/gdb.base/solib-mismatch-libmod.c new file mode 100644 index 0000000..3b025a8 --- /dev/null +++ b/gdb/testsuite/gdb.base/solib-mismatch-libmod.c @@ -0,0 +1,29 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2013 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + + +int _bar = 21; + +int bar(void) +{ + return 42 - _bar; +} + +int foo(void) +{ + return 24 + bar(); +} diff --git a/gdb/testsuite/gdb.base/solib-mismatch.c b/gdb/testsuite/gdb.base/solib-mismatch.c new file mode 100644 index 0000000..8a7f58f --- /dev/null +++ b/gdb/testsuite/gdb.base/solib-mismatch.c @@ -0,0 +1,68 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2013 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + + +#include +#include +#include +#include +#include + +/* The following defines must correspond to solib-mismatch.exp */ + +#define DIRNAME "solib-mismatch_wd" +#define LIB "./solib-mismatch.so" + +int main(int argc, char *argv[]) +{ + void *h; + int (*foo)(void); + char buff[1024]; + char *p; + + p = strstr (argv[0], DIRNAME); + + if (p == NULL) + { + printf ("ERROR - %s could not be found in argv[0]\n", DIRNAME); + return 1; + } + + p += strlen (DIRNAME); + + memcpy (buff, argv[0], p - argv[0]); + + buff[p - argv[0]] = '\0'; + + if (chdir (buff) != 0) + { + printf ("ERROR - Could not cd to %s\n", buff); + return 1; + } + + h = dlopen(LIB, RTLD_NOW); + + if (h == NULL) + { + printf ("ERROR - could not open lib %s\n", LIB); + return 1; + } + foo = dlsym(h, "foo"); /* set breakpoint 1 here */ + dlclose(h); + return 0; +} + diff --git a/gdb/testsuite/gdb.base/solib-mismatch.exp b/gdb/testsuite/gdb.base/solib-mismatch.exp new file mode 100644 index 0000000..f26ac49 --- /dev/null +++ b/gdb/testsuite/gdb.base/solib-mismatch.exp @@ -0,0 +1,157 @@ +# Copyright 2013 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . */ + +standard_testfile +set executable $testfile + +# Test overview: +# generate two shared objects. One that will be used by the process +# and another, modified, that will be found by gdb. Gdb should +# detect the mismatch and refuse to use mismatched shared object. + +if { [get_compiler_info] } { + untested "get_compiler_info failed." +} + +# First version of the object, to be loaded by ld +set srclibfilerun ${testfile}-lib.c + +# Modified version of the object to be loaded by gdb +# Code in -libmod.c is tuned so it gives a mismatch but +# leaves .dynamic at the same point. +set srclibfilegdb ${testfile}-libmod.c + +# So file name: +set binlibfilebase ${testfile}.so + +# Setup run directory (where program is run from) +# It contains executable and '-lib' version of the library. +set binlibfiledirrun [standard_output_file ${testfile}_wd] +set binlibfilerun ${binlibfiledirrun}/${binlibfilebase} + +# Second solib version is in current directory, '-libmod' version. +set binlibfiledirgdb [standard_output_file ""] +set binlibfilegdb ${binlibfiledirgdb}/${binlibfilebase} + +# Executeable +set srcfile ${testfile}.c +set executable ${testfile} +set objfile [standard_output_file ${executable}.o] +set binfile [standard_output_file ${executable}] + +send_user "Current WD: [eval pwd]\r\n" + +file mkdir "${binlibfiledirrun}" + +set exec_opts {} + +if { ![istarget "*-*-nto-*"] } { + set exec_opts [list debug shlib_load] +} + +if { [prepare_for_testing $testfile.exp $executable $srcfile $exec_opts] != 0 } { + return -1 +} + +if { [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfilerun}" "${binlibfilerun}" [list debug ldflags=-Wl,-soname,${binlibfilebase},--build-id]] != "" + || [gdb_gnu_strip_debug "${binlibfilerun}"] + || [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfilegdb}" "${binlibfilegdb}" [list debug ldflags=-Wl,-soname,${binlibfilebase},--build-id]] != "" } { + untested "gdb_compile_shlib failed." + return -1 +} + + +proc solib_matching_test { solibfile symsloaded msg } { + global gdb_prompt + global testfile + global executable + global srcdir + global subdir + global binlibfiledirrun + global binlibfiledirgdb + global srcfile + + clean_restart ${binlibfiledirrun}/${executable} + + send_gdb "set solib-search-path \"${binlibfiledirgdb}\"\n" + send_gdb "cd ${binlibfiledirgdb}\n" +# Do not auto load shared libraries, the test needs to have control +# over when the relevant output gets printed + send_gdb "set auto-solib-add off\n" + + set bp_location [gdb_get_line_number "set breakpoint 1 here"] + + gdb_breakpoint ${srcfile}:${bp_location} temporary no-message + + gdb_run_cmd { ${binlibfiledirrun} } + gdb_expect { + -re "set breakpoint 1 here.*${gdb_prompt} $" { + } + default { + untested "${msg} - Failed to hit breakpoint at ${bp_location}" + return -1 + } + } + + send_gdb "sharedlibrary\n" + gdb_expect { + -re "${gdb_prompt} $" { + } + default { + untested "${msg} - sharedlibrary failure" + return -1 + } + } + + gdb_test "info sharedlibrary ${solibfile}" \ + "From.*To.*Syms.*Read.*Shared.*\r\n.*${symsloaded}.*${solibfile}.*" \ + "${msg} - Symbols for ${solibfile} loaded: expected '${symsloaded}'" + return 0 +} + +# Copy binary to working dir so it pulls in the library from that dir +# (by the virtue of $ORIGIN). +file copy -force "${binlibfiledirgdb}/${executable}" \ + "${binlibfiledirrun}/${executable}" + +# Test unstripped, .dynamic matching +solib_matching_test "${binlibfilebase}" "No" \ + "test unstripped, .dynamic matching" + +# Keep original so for debugging purposes +file copy -force "${binlibfilegdb}" "${binlibfilegdb}-orig" +set objcopy_program [transform objcopy] +set result [catch "exec $objcopy_program --only-keep-debug ${binlibfilegdb}"] +if {$result != 0} { + untested "test --only-keep-debug" + return -1 +} + +# Test --only-keep-debug, .dynamic matching so +solib_matching_test "${binlibfilebase}" "No" \ + "test --only-keep-debug" + +# Keep previous so for debugging puroses +file copy -force "${binlibfilegdb}" "${binlibfilegdb}-orig1" + +# Copy loaded so over the one gdb will find +file copy -force "${binlibfilerun}" "${binlibfilegdb}" + +# Now test it does not mis-invalidate matching libraries +solib_matching_test "${binlibfilebase}" "Yes" \ + "test matching libraries" + + + -- 1.7.10.4