From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17194 invoked by alias); 6 Apr 2013 15:49:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17184 invoked by uid 89); 6 Apr 2013 15:49:17 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 06 Apr 2013 15:49:14 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r36Fn56p006250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Apr 2013 11:49:05 -0400 Received: from host2.jankratochvil.net (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r36Fn1bC019017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 6 Apr 2013 11:49:04 -0400 Date: Sun, 07 Apr 2013 06:06:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org, Gary Benson Subject: Re: [patch] validate binary before use Message-ID: <20130406154900.GB27972@host2.jankratochvil.net> References: <20130328183727.GA14798@host2.jankratochvil.net> <515B0632.1040502@qnx.com> <20130402165306.GA9479@host2.jankratochvil.net> <515B12D1.7050505@qnx.com> <20130403180917.GA6102@host2.jankratochvil.net> <515CDF7F.5020403@qnx.com> <20130404081302.GA4099@host2.jankratochvil.net> <515D7A09.5010305@qnx.com> <20130405114732.GA11684@host2.jankratochvil.net> <515ECC5C.7040609@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515ECC5C.7040609@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-04/txt/msg00160.txt.bz2 On Fri, 05 Apr 2013 15:06:36 +0200, Aleksandar Ristovski wrote: > On 13-04-05 07:47 AM, Jan Kratochvil wrote: > > I was talking about linux-nat to differentiate it from gdbserver. But in fact > > the non-gdbserver (local) patchset part is in solib-svr4.c, not linux-nat.c. > > Only that commonly when one uses the local part of solib-svr4.c one is using > > linux-nat.c that time - but one could be using for example sparc-sol2-nat.c > > instead. > > What I am suggesting is that linux-nat (and any other *-nat) should > implement TARGET_OBJECT_LIBRARIES_SVR4. That seems as a great idea, I somehow completely missed that. It should be enough to implement it to linux-nat (by moving the gdbserver/linux-low.c implementation to gdb/common/ ), other *-nat targets can implement later if they want to. Would you like to check in your patch as is or to rebase it on top of the TARGET_OBJECT_LIBRARIES_SVR4-only implementation? I do not think too big part of your patch is affected by it, though. The linux-nat TARGET_OBJECT_LIBRARIES_SVR4 part should be done quickly I hope. This may even unify more the Gary's patch, although he has already the solib-svr4.c part complete. Jan