From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12870 invoked by alias); 2 Apr 2013 14:12:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12808 invoked by uid 89); 2 Apr 2013 14:12:01 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Apr 2013 14:11:57 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r32EBs6M011807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Apr 2013 10:11:54 -0400 Received: from host2.jankratochvil.net (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r32EBodr001493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 2 Apr 2013 10:11:53 -0400 Date: Tue, 02 Apr 2013 15:26:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Gareth McMullin , gdb-patches@sourceware.org Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275 Message-ID: <20130402141149.GA16203@host2.jankratochvil.net> References: <20130325195832.GA15218@host2.jankratochvil.net> <515478BE.3030801@redhat.com> <20130329140245.GA16492@host2.jankratochvil.net> <515AE52D.9020403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515AE52D.9020403@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-04/txt/msg00044.txt.bz2 On Tue, 02 Apr 2013 16:03:25 +0200, Pedro Alves wrote: > On 03/29/2013 02:02 PM, Jan Kratochvil wrote: > > I agree this fix is better. I will revert the previous check-in after this > > check-in. > > Now pushed. Checked in the revert: http://sourceware.org/ml/gdb-cvs/2013-04/msg00016.html and for 7.6: http://sourceware.org/ml/gdb-cvs/2013-04/msg00017.html Thanks, Jan http://sourceware.org/ml/gdb-cvs/2013-04/msg00016.html --- src/gdb/ChangeLog 2013/04/02 13:51:06 1.15355 +++ src/gdb/ChangeLog 2013/04/02 14:09:08 1.15356 @@ -1,3 +1,9 @@ +2013-04-02 Jan Kratochvil + + Revert this patch: + PR gdb/15275 + * remote.c (remote_get_trace_status): Include putpkt in TRY_CATCH. + 2013-04-02 Pedro Alves PR gdb/15275 --- src/gdb/remote.c 2013/04/02 13:51:07 1.536 +++ src/gdb/remote.c 2013/04/02 14:09:08 1.537 @@ -10713,9 +10713,10 @@ trace_regblock_size = get_remote_arch_state ()->sizeof_g_packet; + putpkt ("qTStatus"); + TRY_CATCH (ex, RETURN_MASK_ERROR) { - putpkt ("qTStatus"); p = remote_get_noisy_reply (&target_buf, &target_buf_size); } if (ex.reason < 0)