From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10638 invoked by alias); 29 Mar 2013 13:25:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10606 invoked by uid 89); 29 Mar 2013 13:25:33 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 29 Mar 2013 13:25:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2TDPPFo028720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Mar 2013 09:25:25 -0400 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2TDPL7d031161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 29 Mar 2013 09:25:24 -0400 Date: Fri, 29 Mar 2013 16:19:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch 6/6] gdbserver build-id attribute generator Message-ID: <20130329132521.GA13075@host2.jankratochvil.net> References: <51278984.3070208@qnx.com> <20130310210843.GG21130@host2.jankratochvil.net> <514C56D4.1060906@qnx.com> <20130326204157.GC12291@host2.jankratochvil.net> <51530465.30503@qnx.com> <20130327145028.GA17905@host2.jankratochvil.net> <515353CF.40601@qnx.com> <5154ADD2.9040206@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5154ADD2.9040206@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-03/txt/msg01106.txt.bz2 On Thu, 28 Mar 2013 21:53:38 +0100, Aleksandar Ristovski wrote: > 2) lrfind_mapping_entry can not check for vaddr + offset as offset > is file offset, and for some shared objects this will not match even > though the vaddr of the entry with zero offset is valid. This is not yet a new review but: When it does not match? ELF is designed so that each segment can be placed arbitrarily but this code is Linux specific and Linux guarantees all segments will be placed in memory with the same displacement against the file. So in Linux file offset vs. memory offset is the same. > Stepping through code now shows some of the things you couldn't see, > like e.g. why is there so->build_id, and where is it being set (you > couldn't see it being set before as qXfer_library was broken). There was also a mistake by me I did not notice it. Thanks, Jan