Re: [PATCH 02/10] clean up allocation of bfd filenames

Tom Tromey
2012-07-20T16:30:40Z

Jan> Would not it be worth propose this bfd filename memory storage
Jan> globally in bfd/ ?

Tom> I went back and forth on this.

Tom> I think it would probably be better in general, but I wasn't too
Tom> enthused about auditing a lot of code that I don't know well to make the
Tom> change globally.

I remembered the argument that made me decide to do it in gdb.

BFD made a choice, long ago, to have clients manage the memory for the
filename. My patch just changes one client to handle it in a uniform
way. Changing other clients, or changing the library itself, might make
sense -- but it might not, and I don't really know anything about some
of these clients, like 'ld'. So I figured it was ok to leave things in
this state.

Tom