From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24134 invoked by alias); 29 Mar 2013 00:29:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24103 invoked by uid 89); 29 Mar 2013 00:29:52 -0000 X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 29 Mar 2013 00:29:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A4BCB1C7C31; Thu, 28 Mar 2013 20:29:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mpYHWejYwLXr; Thu, 28 Mar 2013 20:29:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 74B351C7C0D; Thu, 28 Mar 2013 20:29:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C7B76C0342; Thu, 28 Mar 2013 17:29:46 -0700 (PDT) Date: Fri, 29 Mar 2013 05:59:00 -0000 From: Joel Brobecker To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch] cleanup: Wunused coff-pe-read Message-ID: <20130329002946.GI4758@adacore.com> References: <5109EE44.5020605@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5109EE44.5020605@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg01090.txt.bz2 > Aleksandar Ristovski > > * coff-pe-read.c (add_pe_exported_sym): Remove unused DLL_NAME_LEN. > (add_pe_forwarded_sym): Remove unused SECTION, DLL_NAME_LEN. > (read_pe_exported_syms): Remove unused EXPORTIX. > (pe_text_section_offset): Remove unused OPTHDR_OFS, NUM_ENTRIES, > EXPORT_RVA, EXPORT_SIZE, EXPPTR, EXP_FUNCBASE, EXPDATA, > ERVA, NAME_RVAS, ORDINALS, NEXP, ORDBASE, DLL_NAME. Approved. One nit: all-cap ENTITY_NAME means "the value of entity_name". You are removing the entities themselves, so their name should not be capitalized. I missed that in the two other patches I just approved. -- Joel