From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19640 invoked by alias); 28 Mar 2013 20:14:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19522 invoked by uid 89); 28 Mar 2013 20:13:58 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 28 Mar 2013 20:13:55 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2SKDpnO013036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Mar 2013 16:13:51 -0400 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2SKDlm7002631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 28 Mar 2013 16:13:50 -0400 Date: Thu, 28 Mar 2013 22:38:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch 5/6] Move linux_find_memory_regions_full & co. Message-ID: <20130328201347.GA9375@host2.jankratochvil.net> References: <51278984.3070208@qnx.com> <20130310210831.GF21130@host2.jankratochvil.net> <514C56D0.3020805@qnx.com> <20130326165839.GB12291@host2.jankratochvil.net> <515353C8.5080100@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515353C8.5080100@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-03/txt/msg01074.txt.bz2 On Wed, 27 Mar 2013 21:17:12 +0100, Aleksandar Ristovski wrote: > Moves should now be clean, without mods. [...] > @@ -3560,6 +3495,10 @@ target_fileio_read_alloc_1 (const char *filename, > make_cleanup (free_current_contents, &memory_to_free); > retval = read_alloc (buf_p, fd, target_fileio_read_alloc_1_pread, padding, > &memory_to_free); > + if (retval >= 0) > + /* Returned allocated memory is interesting for the caller. */ > + memory_to_free = NULL; The formatting according to GDB specific style in gdb/doc/gdbint.texinfo: if (retval >= 0) { /* Returned allocated memory is interesting for the caller. */ memory_to_free = NULL; } > + > do_cleanups (close_cleanup); > return retval; > } This part should have been in the previous patch. No need to repost but please rearrange it during the final check-in. Jan