Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA, RFA 7.6] Improve help for, e.g., running gdb in build tree.
Date: Thu, 28 Mar 2013 12:00:00 -0000	[thread overview]
Message-ID: <20130327215401.GE4758@adacore.com> (raw)
In-Reply-To: <20819.16279.468828.807108@ruffy2.mtv.corp.google.com>

> 2013-03-27  Doug Evans  <dje@google.com>
> 
> 	* python/python.c (finish_python_initialization): Provide suggestion
> 	for how to tell gdb to find its python files.

FWIW, OK for me as well (commenting on the second version).

> 
> Index: python.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/python/python.c,v
> retrieving revision 1.111
> diff -u -p -r1.111 python.c
> --- python.c	12 Mar 2013 17:39:45 -0000	1.111
> +++ python.c	27 Mar 2013 18:48:40 -0000
> @@ -1711,9 +1711,13 @@ finish_python_initialization (void)
>    if (gdb_python_module == NULL)
>      {
>        gdbpy_print_stack ();
> -      warning (_("Could not load the Python gdb module from `%s'."),
> +      /* This is passed in one call to warning so that blank lines aren't
> +	 inserted between each line of text.  */
> +      warning (_("\n"
> +		 "Could not load the Python gdb module from `%s'.\n"
> +		 "Limited Python support is available from the _gdb module.\n"
> +		 "Suggest passing --data-directory=/path/to/gdb/data-directory.\n"),
>  		 gdb_pythondir);
> -      warning (_("Limited Python support is available from the _gdb module."));
>        do_cleanups (cleanup);
>        return;
>      }

-- 
Joel


  reply	other threads:[~2013-03-27 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 20:17 Doug Evans
2013-03-27 20:17 ` Tom Tromey
2013-03-27 20:44   ` Doug Evans
2013-03-28 12:00     ` Joel Brobecker [this message]
2013-03-28 19:46       ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130327215401.GE4758@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox