From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15818 invoked by alias); 27 Mar 2013 08:50:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15792 invoked by uid 89); 27 Mar 2013 08:50:32 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 08:50:30 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id CCEA9520652; Wed, 27 Mar 2013 09:50:27 +0100 (CET) Date: Wed, 27 Mar 2013 10:53:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling Message-ID: <20130327085027.GB22857@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr> <83y5d9xrqt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83y5d9xrqt.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg01006.txt.bz2 On Mar 27 08:48, Eli Zaretskii wrote: > > From: "Pierre Muller" > > Index: windows-nat.c > > =================================================================== > > RCS file: /cvs/src/src/gdb/windows-nat.c,v > > retrieving revision 1.245 > > diff -u -p -r1.245 windows-nat.c > > --- windows-nat.c 23 Mar 2013 10:48:23 -0000 1.245 > > +++ windows-nat.c 26 Mar 2013 21:39:57 -0000 > > @@ -990,7 +990,7 @@ handle_output_debug_string (struct targe > > retval = strtoul (p, &p, 0); > > if (!retval) > > retval = main_thread_id; > > - else if ((x = (LPCVOID) strtoull (p, NULL, 0)) > > + else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0)) > > && ReadProcessMemory (current_process_handle, x, > > &saved_context, > > __COPY_CONTEXT_SIZE, &n) > > Is the cast to LPCVOID really needed? What if you drop it (and not > add the cast to uintptr_t)? x is a pointer, so it's 4 byte on 32 bit and 8 byte on 64 bit. If you drop the casts, you get the warning in the 32 bit case again. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat