From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3935 invoked by alias); 26 Mar 2013 23:43:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3915 invoked by uid 89); 26 Mar 2013 23:43:25 -0000 X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 23:43:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2A4422E698; Tue, 26 Mar 2013 19:43:21 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9rNFtaNlleTI; Tue, 26 Mar 2013 19:43:21 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 866E22E8C3; Tue, 26 Mar 2013 19:43:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E00DCC23B9; Tue, 26 Mar 2013 16:43:18 -0700 (PDT) Date: Wed, 27 Mar 2013 07:53:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org, 'Corinna Vinschen' Subject: Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling Message-ID: <20130326234318.GA4758@adacore.com> References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000101ce2a6b$8c855a60$a5900f20$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00997.txt.bz2 > cc1: warnings being treated as errors > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string': > ../../src/gdb/windows-nat.c:993:18: error: cast to pointer from integer of > different size > Makefile:972: recipe for target `windows-nat.o' failed > make: *** [windows-nat.o] Error 1 > make: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb' > > This failure can be fixed by this simple patch, which should > not affect the unreleased 64-bit Cygwin, a confirmation > by Corinna would be nice on this part... > > > ChangeLog entry: > > 2013-03-26 Pierre Muller > > * windows-nat.c (handle_output_debug_string): Avoid typecast > from integer of different size warning. This looks about right to me. Let's wait for Corinna to confirm that it's OK with her too and commit. > Index: windows-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/windows-nat.c,v > retrieving revision 1.245 > diff -u -p -r1.245 windows-nat.c > --- windows-nat.c 23 Mar 2013 10:48:23 -0000 1.245 > +++ windows-nat.c 26 Mar 2013 21:39:57 -0000 > @@ -990,7 +990,7 @@ handle_output_debug_string (struct targe > retval = strtoul (p, &p, 0); > if (!retval) > retval = main_thread_id; > - else if ((x = (LPCVOID) strtoull (p, NULL, 0)) > + else if ((x = (LPCVOID) (uintptr_t) strtoull (p, NULL, 0)) > && ReadProcessMemory (current_process_handle, x, > &saved_context, > __COPY_CONTEXT_SIZE, &n) > > -- Joel