From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15132 invoked by alias); 26 Mar 2013 16:58:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14947 invoked by uid 89); 26 Mar 2013 16:58:49 -0000 X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 16:58:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGwhma014294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Mar 2013 12:58:44 -0400 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGwdEc015877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 26 Mar 2013 12:58:42 -0400 Date: Tue, 26 Mar 2013 18:27:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch 5/6] Move linux_find_memory_regions_full & co. Message-ID: <20130326165839.GB12291@host2.jankratochvil.net> References: <51278984.3070208@qnx.com> <20130310210831.GF21130@host2.jankratochvil.net> <514C56D0.3020805@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514C56D0.3020805@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-03/txt/msg00973.txt.bz2 On Fri, 22 Mar 2013 14:04:16 +0100, Aleksandar Ristovski wrote: > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -3477,69 +3477,6 @@ target_fileio_read_alloc_1_pread (int handle, gdb_byte *read_buf, int len, [...] > -read_alloc (gdb_byte **buf_p, int handle, read_alloc_pread_ftype *pread_func, > - int padding, void **memory_to_free_ptr) [...] > - buf = xrealloc (buf, buf_alloc); > - } vs. > --- a/gdb/common/common-utils.c > +++ b/gdb/common/common-utils.c > @@ -348,3 +348,95 @@ skip_spaces_const (const char *chp) [...] > +read_alloc (gdb_byte **buf_p, int handle, read_alloc_pread_ftype *pread_func, > + int padding, void **memory_to_free_ptr) [...] > + buf = xrealloc (buf, buf_alloc); > + if (memory_to_free_ptr != NULL) > + *memory_to_free_ptr = buf; > + } This is not a move, one does not see what has really changed in the diffs. > -read_stralloc (const char *filename, read_stralloc_func_ftype *func) > -{ > - gdb_byte *buffer; > - char *bufstr; > - LONGEST i, transferred; > - > - transferred = func (filename, &buffer, 1); vs. > +read_stralloc (const char *filename, read_stralloc_func_ftype *func) > +{ > + char *buffer; > + LONGEST i, transferred; > + > + transferred = func (filename, (gdb_byte **) &buffer, 1); Likewise this is not just a move. One cannot review it before picking each function and comparing them by hand, this is why the patchset was split into the change + move parts, but you made changes in the 'move' parts without updating the 'change' parts. Please update the patchset. Going to look at the real code changes of the last parts. Thanks, Jan