From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8088 invoked by alias); 26 Mar 2013 16:53:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7923 invoked by uid 89); 26 Mar 2013 16:52:54 -0000 X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 16:52:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGqlnL026225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Mar 2013 12:52:48 -0400 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2QGqhs9022664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 26 Mar 2013 12:52:46 -0400 Date: Tue, 26 Mar 2013 18:11:00 -0000 From: Jan Kratochvil To: Aleksandar Ristovski Cc: "gdb-patches@sourceware.org" Subject: Re: [patch 4/6] Prepare linux_find_memory_regions_full & co. for move Message-ID: <20130326165242.GA12291@host2.jankratochvil.net> References: <51278984.3070208@qnx.com> <20130310210820.GE21130@host2.jankratochvil.net> <514C56CB.4070207@qnx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514C56CB.4070207@qnx.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-03/txt/msg00972.txt.bz2 On Fri, 22 Mar 2013 14:04:11 +0100, Aleksandar Ristovski wrote: > --- a/gdb/target.c > +++ b/gdb/target.c [...] > @@ -3540,15 +3578,17 @@ target_fileio_read_alloc (const char *filename, gdb_byte **buf_p) > are returned as allocated but empty strings. A warning is issued > if the result contains any embedded NUL bytes. */ > > -char * > -target_fileio_read_stralloc (const char *filename) > +typedef LONGEST (read_stralloc_func_ftype) (const char *filename, > + gdb_byte **buf_p, int padding); > + > +static char * > +read_stralloc (const char *filename, read_stralloc_func_ftype *func) > { > gdb_byte *buffer; > char *bufstr; > LONGEST i, transferred; > > - transferred = target_fileio_read_alloc_1 (filename, &buffer, 1); > - bufstr = (char *) buffer; This line is accidentally deleted, it should not be. > + transferred = func (filename, &buffer, 1); > > if (transferred < 0) > return NULL;