From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16970 invoked by alias); 26 Mar 2013 18:11:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16887 invoked by uid 89); 26 Mar 2013 18:10:54 -0000 X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 18:10:51 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 8487833BE0E; Tue, 26 Mar 2013 18:10:49 +0000 (UTC) From: Mike Frysinger To: "Hans-Peter Nilsson" Subject: Re: Recent simulator patches broke many sims Date: Tue, 26 Mar 2013 19:49:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.7.6; KDE/4.6.5; x86_64; ; ) Cc: joel.sherrill@oarcorp.com, gdb-patches@sourceware.org References: <201303261712.r2QHCcvp013983@ignucius.se.axis.com> In-Reply-To: <201303261712.r2QHCcvp013983@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart227399918.auxhmXfu5e"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201303261415.19076.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-03/txt/msg00979.txt.bz2 --nextPart227399918.auxhmXfu5e Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2897 On Tuesday 26 March 2013 13:12:38 Hans-Peter Nilsson wrote: > From: Mike Frysinger > On Sunday 24 March 2013 19:23:28 Hans-Peter Nilsson wrote: > > You need a board (make check RUNTESTFLAGS=3D--target_board=3D$board > > with e.g. board=3Dcris-sim). All boards are in "recent" > > dejagnu-1.5 IIRC and most in ancient dejagnu-1.4.4. You need > > installed binutils (e.g. in some temp location added to PATH for > > the duration of the test-run) for each sim configuration as > > mentioned. I don't run with target gcc; not needed for the > > level of smoke test I'm after and I guess not for this change > > either. > >=20 > > that's not entirely true. many (all but cris?) >=20 > I don't think it's different but I don't plan to test without... >=20 > > sims run & > > pass just fine without needing to explicitly pass magic flags. >=20 > It is entirely true that when a board is specified, all work. >=20 > Now that you mention it, someone *did* do some changes to allow > simulator tests to run without specifying a board - IIRC in some > situations, assuming no special linker flags or such needed and > no compiler toolchain (or no flags or libraries using simulator > hooks). Reading ChangeLogs it seems it was you, on 2010-04-26. yes, that was the commit date, but i'd been using it longer than that :) > > i know the Blackfin and frv sims can build & run pretty much > > all their tests w/out requiring board flags. > >=20 > > imo, requiring manual board selection like this is archaic for > > no good reason. >=20 > One good reason IMO is that when specifying a board, all > toolchain parts test alike, rather than sim (after 2010-04-26) > being a special case (and binutils, mostly for not needing to > run things to avoid FAILs or hanging tests). i see it the other way. doing `make check` for all these packages work w/o= ut=20 the user having to dig into esoteric tools (that often times lack=20 documentation, or any real semblance of an entry point). for binutils/gcc/etc..., there are plenty of compile/link/etc... tests that= =20 can be done without needing to know about a board. the sim is special in t= hat=20 testing it requires running code, so it's entirely reasonable for the defau= lt=20 `make check` to setup a state where the tests actually work. if the default `make check` for cris doesn't, then that should be fixed to= =20 provide a reasonable default. if you're telling everyone "in order to test= =20 the cris sim, you have to use RUNTESTFLAGS=3D--target_board=3Dcris-sim", th= en make=20 that the default board already. there's absolutely no reason to force this= =20 upon people who are trying to hack on the core sim and/or other sims, and w= ant=20 to verify they didn't break other sims. for many sims, it's hard enough as it is just to try and guess the magic tu= ple=20 that'll pass all the deprecated/enable checks. -mike --nextPart227399918.auxhmXfu5e Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRUeW2AAoJEEFjO5/oN/WBVPYP/jic6Zg0VjqgbSRyWbWECNch v8AlpZca9FK9GZx1hFuyeIlfsQB6QqlMaVKWkpSrx4/OUh2/ORaxQPdhE5cB0H1A XzkAUBLg2DEsgct5ZttT7LcCeEmqK2P9SyDTerxkAainEGUf2+ct9QcgXJK3Me0N ZdUbefUcsoWGrXteA2fhBZC2taWt36k6HA+AWe/uj/umrAnDam3eoCCkqQ1LJX9V vdbRKly5i2YmVN4BidR7mxN9D4ruRQ8NlNeSlRgirkXjQlpceJY0KIK9CcU6OorW F20zQG9/o0u7XA+moZeBrFvAHNe2XQBUEpqryCMKBVVcT97p0CG+g0t8nYwnW+yx ke2CYv0knzUSM0P5auDSAAM5tL0BVmMg7M109tIOTbIK8JDJxE9CRThluBubmqYo yBkWZ1g3AOcf7guprr+IOFXyyfoLFD6GqVo0t/lqWXkgY+h8nJvVBXTnp2gz9HB5 JugBwU7MZcI8vx7ZcvBwooDvnAKjyEwoYFuwP9+Q4y9Z5MK0YFCliIv6aW1PTALv 0jymmMiaxTO65cgXtBEEW2IITigXs3ozjIJVYEx6+tXC+rXwxhCwYyQMFpjHmzNK BFi1/SI3szcwuZI2Ay0sZv4yYjbMjY2E/Wz/IJn2rhgpBFx67furT2HYkUdhI+O9 UnScT+rAgfR1Hbpive05 =L3OU -----END PGP SIGNATURE----- --nextPart227399918.auxhmXfu5e--