From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29609 invoked by alias); 25 Mar 2013 16:25:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29582 invoked by uid 89); 25 Mar 2013 16:25:28 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 16:25:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 23D112E9FF; Mon, 25 Mar 2013 12:25:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8nlq7Qj66zqR; Mon, 25 Mar 2013 12:25:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B8D2B2E4D1; Mon, 25 Mar 2013 12:25:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1B34EC08C3; Mon, 25 Mar 2013 09:25:25 -0700 (PDT) Date: Mon, 25 Mar 2013 18:10:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org, palves@redhat.com, jan.kratochvil@redhat.com, ralf.corsepius@rtems.org, vapier@gentoo.org, joel.sherrill@oarcorp.com Subject: Re: one week to gdb-7.6 release? Message-ID: <20130325162524.GK5447@adacore.com> References: <20130320160032.GC5447@adacore.com> <83vc8myoyb.fsf@gnu.org> <83ehf64cfs.fsf@gnu.org> <20130323162534.GI5447@adacore.com> <834ng23soj.fsf@gnu.org> <20130325151825.GJ5447@adacore.com> <83k3ov1mo0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83k3ov1mo0.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00941.txt.bz2 > But then why do we need an implementation in posix-hdep.c at all? I did not mean to say that we do need an implementation in posix-hdep, just saying that we might someday in the future - and if we do, a comment explaining the currrent implemention would help the next person looking at it. > The > code in main.c already does > > #ifdef __MINGW32__ > /* On Windows, argv[0] is not necessarily set to absolute form when > GDB is found along PATH, without which relocation doesn't work. */ > gdb_program_name = windows_get_absolute_argv0 (argv[0]); > #else > gdb_program_name = xstrdup (argv[0]); > #endif > > Is moving that to posix-hdep.c just to avoid an ifdef? The main purpose is to move the code away out of windows-nat, which is only linked in native debuggers, not cross ones - so that building a cross debugger hosted on Windows will work again. Basically, your new function is really only dependent on the host, whereas the -nat file makes the assumption that host & target are Windows. -- Joel