From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21491 invoked by alias); 23 Mar 2013 16:25:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21466 invoked by uid 89); 23 Mar 2013 16:25:42 -0000 X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 23 Mar 2013 16:25:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 657F02E92F; Sat, 23 Mar 2013 12:25:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BKdR-8hlSIdT; Sat, 23 Mar 2013 12:25:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1D8A52E5B6; Sat, 23 Mar 2013 12:25:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0EE29C269B; Sat, 23 Mar 2013 09:25:35 -0700 (PDT) Date: Sun, 24 Mar 2013 00:01:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org, palves@redhat.com, jan.kratochvil@redhat.com, ralf.corsepius@rtems.org, vapier@gentoo.org, joel.sherrill@oarcorp.com Subject: Re: one week to gdb-7.6 release? Message-ID: <20130323162534.GI5447@adacore.com> References: <20130320160032.GC5447@adacore.com> <83vc8myoyb.fsf@gnu.org> <83ehf64cfs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83ehf64cfs.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00875.txt.bz2 Hi Eli, > Committed to the trunk as below. This incorporates comments from Jan. > OK to commit the same to the 7.6 branch? > 2013-03-18 Eli Zaretskii > > * windows-nat.c (windows_get_absolute_argv0): New function. > * windows-nat.h: Add its prototype. > > * main.c (get_init_files): Use filename_ncmp instead of strncmp. > Use IS_DIR_SEPARATOR instead of looking for a character inside > SLASH_STRING. Include filenames.h. > (captured_main) [__MINGW32__]: Make argv[0] absolute, so that > relocate_gdb_directory works when passed gdb_program_name. > Include windows-nat.h. I think that the patch, as is, breaks the windows-hosted cross-debugger builds. windows-nat.o is only linked in when configured as a native debugger: if test "${gdb_native}" = "yes"; then host_makefile_frag=${srcdir}/config/${gdb_host_cpu}/${gdb_host}.mh I think that the standard approach in this case would be to define a function in utils.h, and have its implementation in both posix-hdep.c and mingw-hdep.c. A minor nitpick on coding style: Can you add an empty line between the comment documenting a function ands its definition? Thank you, -- Joel