From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19270 invoked by alias); 20 Mar 2013 08:51:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19229 invoked by uid 89); 20 Mar 2013 08:51:30 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 20 Mar 2013 08:51:27 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id BB75C5203F8; Wed, 20 Mar 2013 09:51:24 +0100 (CET) Date: Wed, 20 Mar 2013 09:36:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [patch] windows-nat.c: Fix offset problem in signal string handling Message-ID: <20130320085124.GH20727@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130319212554.GE4506@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg00729.txt.bz2 On Mar 19 14:25, Joel Brobecker wrote: > > Alternatively the call to string_to_core_addr could be replaced with a > > call to `strtoull (p, NULL, 0)'. Since this code is only supported on > > Cygwin, it's safe to assume that the strtoull function exists. > > I would go for that option, mostly because you already use strtol > to parse the beginning of that string... > > > Version 2: > > > > * windows-nat.c (handle_output_debug_string): Replace call > > to string_to_core_addr with call to strtoull. Thanks, applied. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat