From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16870 invoked by alias); 15 Mar 2013 17:55:14 -0000 Received: (qmail 16861 invoked by uid 22791); 15 Mar 2013 17:55:13 -0000 X-SWARE-Spam-Status: No, hits=-10.2 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Mar 2013 17:55:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 0B0C2335E2D; Fri, 15 Mar 2013 17:55:08 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [patch, simulator] Fix sim_command_completer arguments. Date: Fri, 15 Mar 2013 18:01:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.7.6; KDE/4.6.5; x86_64; ; ) Cc: "Steve Ellcey " References: <2642b17f-5e3b-41b2-a985-ffcaa9220e95@BAMAIL02.ba.imgtec.org> In-Reply-To: <2642b17f-5e3b-41b2-a985-ffcaa9220e95@BAMAIL02.ba.imgtec.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart50508161.F2u34gKesJ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201303151358.16272.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00681.txt.bz2 --nextPart50508161.F2u34gKesJ Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1230 On Friday 15 March 2013 13:31:59 Steve Ellcey wrote: > My build of gdb and sim have recently started failing with: >=20 > /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c: In function > '_initialize_remote_sim': > /local/home/sellcey/nightly2/src/gdb/gdb/remote-sim.c:1323: error: passing > argument 2 of 'set_cmd_completer' from incompatible pointer type > /local/home/sellcey/nightly2/src/gdb/gdb/command.h:161: note: expected > 'struct VEC_char_ptr * (*)(struct cmd_list_element *, const char *, const > char *)' but argument is of type 'struct VEC_char_ptr * (*)(struct > cmd_list_element *, char *, char *)' >=20 > I didn't see any change in gdb/sim that might be causing this but I am > building with the latest (ToT) GCC and I think a change there might have > caused GCC to start catching this discrepency in argument types. I would > like to fix it by adding the 'const' modifier to the sim_command_completer > text and word arguments so that its argument types match > filename_completer, expression_completer, etc. >=20 > Tested by building gdb and sim on mips-mti-elf. I didn't test all the > platforms that I modified but unless I made a typo there shouldn't be any > problems. >=20 > OK to checkin? OK -mike --nextPart50508161.F2u34gKesJ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRQ2E4AAoJEEFjO5/oN/WBMtAQAJbZ5XVm6n3PAj5xULw4ZpUK Os4w1gWt56VZpmFbIrg3usASMjRS5Wux0Yaisw+RDiuFIzkhCBr1dIvvjW9tqQsN 3xA0Shs42Rzritv+SNm9q+KiUSlELV22ZH1JmoNQQPwBlvsxm5jQGt350fdkummf /d0iT/4H5sej1y0lPGPwvxKtssyDX3LxxBzE063IG/khr0iT5HzAFSy3Mx/ienJu bYuy22MtDX38lR6r3U+rA9Zx754dnYdPOENZbG/ioNuHovpsz5OtqDVCEcgDfwWo 0h2N9j8rcI2moRkKV4dknqh6d/MtTe01GA/e5DdIcksbpUgxLMzDzkQTZ4cnpmCK XRZtsvGIa8hb6aOVruf1j84tGe9GeYH7zEi4nhBXPtxEUnwnBQoqRSdBSeqpgmGN dnWvjLsdNu9RVODP8dXQBNly8+Y6w9FwODaqM625dRZrHQN7+3X5SLOLRfTLeHL+ ktdW1zCEBMAEGzknGtcWAaBc3KbH1RNuvB49pIyqGNTueUKN6yh0JhYMAM0PimWu xIf2zWQ4xHsP8J/3tpfhNxNhF1dVif44x4fpxYvcDxgMKYNzCB6Be4OqbIdm38YX e5aD9TzeeOS08nTA/CkrYVvLzlr29FT01jKXfDk4WzoYFPsUdcVtuPFdHxqcsMLk 0nNlFObzSsOcsAjzIbOF =+94q -----END PGP SIGNATURE----- --nextPart50508161.F2u34gKesJ--