Re: [draft patch 0/6] Split FYI and some review notes

Jan Kratochvil
2013-03-11T15:07:36Z

On Mon, 11 Mar 2013 15:25:13 +0100, Aleksandar Ristovski wrote:
> On 13-03-10 05:07 PM, Jan Kratochvil wrote:
> > Do not run get_hex_build_id quadratically - currently for each library you
> > open and scan maps/smaps again. Probably the best approach is to scan all
> > l_ld addresses from r_debug first, then qsort them and then linearly match
> > them to the maps/smaps entries. I am not sure but I guess they still should
> > be returned to GDB in their original order from r_debug for some backward and
> > solib-svr4.c compatibility. Also Gary Benson is working on incremental shlib
> > transfers from gdbserver so that it does not clash too much (it will anyway).
> > While just quadratic computation would be in real world acceptable all the
> > open/read/close syscalls I find really needlessly expensive.
>
> I thought it would be an overkill to make it any more optimal. Ideal
> situation would be to send "library loaded"/ "library unloaded"
> events instead of sending the whole list each time.
>
> But sure, I'll do the qsort.

Particularly this shared library list handling has been proven to be
performance critical. All the performance improvements by Gary Benson target
this issue, including sending the '"library loaded"/ "library unloaded"
events' (being worked on).

Ccing Gary as the qsort by l_ld in gdbserver apparently has to clash with his
patch being cooked.

> If you feel strongly, you can take it over. Otherwise, I will finish
> it. I plan some follow up changes to all this.

OK, great, so leaving next update on you now.

> If you want the patches to be attributed to you, that is also fine
> by me, let me know.

I mostly only reformatted your code, I do not mind either way.

Thanks,
Jan