From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30392 invoked by alias); 8 Mar 2013 22:56:15 -0000 Received: (qmail 30375 invoked by uid 22791); 8 Mar 2013 22:56:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 22:56:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 144972E4A5; Fri, 8 Mar 2013 17:56:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id s+2XOSxI2toS; Fri, 8 Mar 2013 17:56:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F1F652E221; Fri, 8 Mar 2013 17:56:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8CA99C15E6; Fri, 8 Mar 2013 17:56:02 -0500 (EST) Date: Fri, 08 Mar 2013 22:56:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC PATCH] hppa-hpux-tdep.c: Fix host dependency. Message-ID: <20130308225602.GB3264@adacore.com> References: <20130308162241.32137.86462.stgit@brno.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130308162241.32137.86462.stgit@brno.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00390.txt.bz2 > I have no way to test this though, other than making sure it compiles. > I'm inclined to just go ahead and put it in, if nobody's up for > testing it. > > Comments? > > 2013-03-08 Pedro Alves > > * hppa-hpux-tdep.c (hppa_hpux_push_dummy_code): Define INSN macro, > use it to rewrite the trampoline buffers with type gdb_byte[], and > undefine the macro. Remove char* cast. FWIW, it looks good to me too. IIRC, John David Anglin is still able to test pa-hpux patches (Tom should be able to confirm that, since he had some SOM patches tested recently). I wish I could too, but we turned our machines off and put them in storage... -- Joel