From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23407 invoked by alias); 8 Mar 2013 13:58:25 -0000 Received: (qmail 23337 invoked by uid 22791); 8 Mar 2013 13:58:22 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 13:58:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28DwBa9031070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 8 Mar 2013 08:58:11 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28Dw7rS029026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Mar 2013 08:58:10 -0500 Date: Fri, 08 Mar 2013 13:58:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v10 21/21] btrace: fix crash when losing the remote connection on process exit Message-ID: <20130308135807.GA15284@host2.jankratochvil.net> References: <1362734168-1725-1-git-send-email-markus.t.metzger@intel.com> <1362734168-1725-22-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362734168-1725-22-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00364.txt.bz2 On Fri, 08 Mar 2013 10:16:08 +0100, Markus Metzger wrote: > The patch will be split and merged into the btrace patch series. OK for the merge. > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -99,16 +99,11 @@ record_btrace_enable_warn (struct thread_info *tp) > static void > record_btrace_disable_callback (void *arg) > { > - volatile struct gdb_exception error; > struct thread_info *tp; > > tp = arg; > > - TRY_CATCH (error, RETURN_MASK_ERROR) > - btrace_disable (tp); > - > - if (error.message != NULL) > - warning ("%s", error.message); > + btrace_disable (tp); > } I do not see how is it related to this patch. But OK with it. > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -870,10 +870,19 @@ struct target_ops > /* Disable branch tracing and deallocate @tinfo. */ > void (*to_disable_btrace) (struct btrace_target_info *tinfo); > > + /* Disable branch tracing and deallocate @tinfo. This function is similar @tinfo -> TINFO in the GNU Coding Standards style (I see it used multiple times already), sorry for the nitpick. > + to to_disable_btrace, except that it is called during teardown and is > + only allowed to perform actions that are safe. A counter-example would > + be attempting to talk to a remote target. */ > + void (*to_teardown_btrace) (struct btrace_target_info *tinfo); Thanks, Jan