From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24764 invoked by alias); 6 Mar 2013 13:33:46 -0000 Received: (qmail 24756 invoked by uid 22791); 6 Mar 2013 13:33:45 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 13:33:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26DXZXk019390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Mar 2013 08:33:35 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r26DXVHr002082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 6 Mar 2013 08:33:34 -0500 Date: Wed, 06 Mar 2013 13:33:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com, Pedro Alves Subject: Re: [patch v9 08/23] gdbserver, linux, btrace: add btrace support for linux-low Message-ID: <20130306133331.GB3365@host2.jankratochvil.net> References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-9-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362416770-19750-9-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00213.txt.bz2 On Mon, 04 Mar 2013 18:05:55 +0100, Markus Metzger wrote: > + if (tinfo != NULL) > + tinfo->ptr_bits = register_size (0) * 8; The diff against Pedro's review is OK; except for the Pedro's complaint on PTR_BITS; but I see it is an abstraction as it is used in gdb/common/ while in gdb/ one needs to use gdbarch_ptr_bit (gdbarch) and in gdbserver/ one needs to use register_size (0). There could be some more general abstraction put in gdb/common/ but I find it acceptable as is for this patch. Thanks, Jan