Re: [patch v9 08/23] gdbserver, linux, btrace: add btrace support for linux-low

Jan Kratochvil
2013-03-05T20:09:19Z

On Mon, 04 Mar 2013 18:05:55 +0100, Markus Metzger wrote:
> Implement btrace target ops in target linux-low using the common linux-btrace
> functions.
>
> 2013-03-04 Markus Metzger <markus.t.metzger@intel.com>
>
> gdbserver/
> * linux-low: Include linux-btrace.h.
> (linux_low_enable_btrace): New function.
> (linux_low_read_btrace): New function.
> (linux_target_ops): Add btrace ops.
> * configure.srv (i[34567]86-*-linux*): Add linux-btrace.o.
> Add srv_linux_btrace=yes.
> (x86_64-*-linux*): Add linux-btrace.o.
> Add srv_linux_btrace=yes.
> * configure.ac: Define HAVE_LINUX_BTRACE.
> * config.in: Regenerated.
> * configure: Regenerated.
[...]
> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index c52cd2e..c4507c8 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -84,6 +84,10 @@
> #endif
> #endif
>
> +#ifdef HAVE_LINUX_BTRACE
> +#include "linux-btrace.h"

Indentation (as it is inside #if*):
# include "linux-btrace.h"

> +#endif
> +
> #ifndef HAVE_ELF32_AUXV_T
> /* Copied from glibc's elf.h. */
> typedef struct

Reviewed by Pedro IIRC.

Thanks,
Jan