Re: [patch v9 05/23] remote, btrace: add branch trace remote ops

Jan Kratochvil
2013-03-05T20:07:48Z

On Mon, 04 Mar 2013 18:05:52 +0100, Markus Metzger wrote:
> Add the gdb remote target operations for branch tracing. We define the following
> packets:
>
> qbtrace query the current thread if new trace data is available
> returns "yes" or "no" or "Enn"
>
> Qbtrace:on enable branch tracing for the current thread
> returns "OK" or "Enn"

This is not right as you changed it to Qbtrace:bts.

>
> Qbtrace:off disable branch tracing for the current thread
> returns "OK" or "Enn"
>
> qXfer:btrace:read read the full branch trace data for the current thread
>
> 2013-03-04 Markus Metzger <markus.t.metzger@intel.com>
>
> * target.h (enum target_object): Add TARGET_OBJECT_BTRACE.
> * remote.c: Include btrace.h.
> (struct btrace_target_info): New struct.
> (remote_supports_btrace): New function.
> (send_Qbtrace): New function.
> (remote_enable_btrace): New function.
> (remote_disable_btrace): New function.
> (remote_btrace_has_changed): New function.
> (remote_read_btrace): New function.
> (init_remote_ops): Add btrace ops.
> (enum <unnamed>): Add btrace packets.
> (struct protocol_feature remote_protocol_features[]): Add btrace packets.
> (_initialize_remote): Add packet configuration for branch tracing.

This was already reviewed before and OK for check-in.

Thanks,
Jan