RE: [patch v9 02/23] linux, btrace: perf_event based branch tracing

Metzger, Markus T
2013-03-06T10:29:40Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Wednesday, March 06, 2013 11:12 AM

> > + /* Make sure the trace data is up-to-date. */
> > + memory_barrier ();
>
> The barrier here makes absolutely no sense to me. It's only a
> compiler barrier and declaring header as volatile should be enough to
> force the compiler to fetch HEADER->data_head from memory.

Removed.

Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052