From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14159 invoked by alias); 5 Mar 2013 20:09:19 -0000 Received: (qmail 14149 invoked by uid 22791); 5 Mar 2013 20:09:18 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 20:09:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r25K9B3T003031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Mar 2013 15:09:11 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r25K97U2016630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 5 Mar 2013 15:09:09 -0500 Date: Tue, 05 Mar 2013 20:09:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v9 08/23] gdbserver, linux, btrace: add btrace support for linux-low Message-ID: <20130305200906.GH2386@host2.jankratochvil.net> References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-9-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362416770-19750-9-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00171.txt.bz2 On Mon, 04 Mar 2013 18:05:55 +0100, Markus Metzger wrote: > Implement btrace target ops in target linux-low using the common linux-btrace > functions. > > 2013-03-04 Markus Metzger > > gdbserver/ > * linux-low: Include linux-btrace.h. > (linux_low_enable_btrace): New function. > (linux_low_read_btrace): New function. > (linux_target_ops): Add btrace ops. > * configure.srv (i[34567]86-*-linux*): Add linux-btrace.o. > Add srv_linux_btrace=yes. > (x86_64-*-linux*): Add linux-btrace.o. > Add srv_linux_btrace=yes. > * configure.ac: Define HAVE_LINUX_BTRACE. > * config.in: Regenerated. > * configure: Regenerated. [...] > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c > index c52cd2e..c4507c8 100644 > --- a/gdb/gdbserver/linux-low.c > +++ b/gdb/gdbserver/linux-low.c > @@ -84,6 +84,10 @@ > #endif > #endif > > +#ifdef HAVE_LINUX_BTRACE > +#include "linux-btrace.h" Indentation (as it is inside #if*): # include "linux-btrace.h" > +#endif > + > #ifndef HAVE_ELF32_AUXV_T > /* Copied from glibc's elf.h. */ > typedef struct Reviewed by Pedro IIRC. Thanks, Jan