From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13724 invoked by alias); 5 Mar 2013 20:08:53 -0000 Received: (qmail 13716 invoked by uid 22791); 5 Mar 2013 20:08:52 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_CP,TW_QX X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 20:08:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r25K8fu6027403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Mar 2013 15:08:41 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r25K8agn032680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 5 Mar 2013 15:08:39 -0500 Date: Tue, 05 Mar 2013 20:08:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v9 07/23] gdbserver, btrace: add generic btrace support Message-ID: <20130305200836.GG2386@host2.jankratochvil.net> References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-8-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362416770-19750-8-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00170.txt.bz2 On Mon, 04 Mar 2013 18:05:54 +0100, Markus Metzger wrote: > Add support to gdbserver to understand branch trace related packages. > > 2013-03-04 Markus Metzger > > gdbserver/ > * target.h (struct target_ops): Add btrace ops. > (target_supports_btrace): New macro. > (target_btrace_has_changed): New macro. > (target_enable_btrace): New macro. > (target_disable_btrace): New macro. > (target_read_btrace): New macro. > * gdbthread.h (struct thread_info): Add btrace field. > * server.c (handle_btrace_general_set): New function. > (handle_btrace_enable): New function. > (handle_btrace_disable): New function. > (handle_general_set): Call handle_btrace_general_set. > (handle_qxfer_btrace): New function. > (struct qxfer qxfer_packets[]): Add btrace entry. > (handle_btrace_query): New function. > (handle_query): Add btrace to supported query, call handle_btrace_query. > * inferiors.c (remove_thread): Disable btrace. [...] > +/* Handle the "Qbtrace" packet. */ > + > +static int > +handle_btrace_general_set (char *own_buf) > +{ > + struct thread_info *thread; > + const char *err; > + char *op; > + > + if (strncmp ("Qbtrace:", own_buf, strlen ("Qbtrace:")) != 0) > + return 0; > + > + op = own_buf + strlen ("Qbtrace:"); > + > + if (!target_supports_btrace ()) > + { > + strcpy (own_buf, "E.Target does not support branch tracing."); > + return -1; > + } > + > + if (ptid_equal (general_thread, null_ptid) > + || ptid_equal (general_thread, minus_one_ptid)) > + { > + strcpy (own_buf, "E.Must select a single thread."); > + return -1; > + } > + > + thread = find_thread_ptid (general_thread); > + if (thread == NULL) > + { > + strcpy (own_buf, "E.No such thread."); > + return -1; > + } > + > + err = NULL; > + > + if (strcmp (op, "on") == 0) > + err = handle_btrace_enable (thread); Again not merged. > + else if (strcmp (op, "off") == 0) > + err = handle_btrace_disable (thread); > + else > + err = "E.Bad Qbtrace operation. Use on or off."; > + > + if (err != 0) > + strcpy (own_buf, err); > + else > + write_ok (own_buf); > + > + return 1; > +} > + Reviewed by Pedro. Thanks, Jan