From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12396 invoked by alias); 5 Mar 2013 20:07:48 -0000 Received: (qmail 12338 invoked by uid 22791); 5 Mar 2013 20:07:46 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_QB X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 20:07:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r25K7Xn6010055 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Mar 2013 15:07:33 -0500 Received: from host2.jankratochvil.net (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r25K7TqJ032399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 5 Mar 2013 15:07:32 -0500 Date: Tue, 05 Mar 2013 20:07:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [patch v9 05/23] remote, btrace: add branch trace remote ops Message-ID: <20130305200729.GE2386@host2.jankratochvil.net> References: <1362416770-19750-1-git-send-email-markus.t.metzger@intel.com> <1362416770-19750-6-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362416770-19750-6-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00168.txt.bz2 On Mon, 04 Mar 2013 18:05:52 +0100, Markus Metzger wrote: > Add the gdb remote target operations for branch tracing. We define the following > packets: > > qbtrace query the current thread if new trace data is available > returns "yes" or "no" or "Enn" > > Qbtrace:on enable branch tracing for the current thread > returns "OK" or "Enn" This is not right as you changed it to Qbtrace:bts. > > Qbtrace:off disable branch tracing for the current thread > returns "OK" or "Enn" > > qXfer:btrace:read read the full branch trace data for the current thread > > 2013-03-04 Markus Metzger > > * target.h (enum target_object): Add TARGET_OBJECT_BTRACE. > * remote.c: Include btrace.h. > (struct btrace_target_info): New struct. > (remote_supports_btrace): New function. > (send_Qbtrace): New function. > (remote_enable_btrace): New function. > (remote_disable_btrace): New function. > (remote_btrace_has_changed): New function. > (remote_read_btrace): New function. > (init_remote_ops): Add btrace ops. > (enum ): Add btrace packets. > (struct protocol_feature remote_protocol_features[]): Add btrace packets. > (_initialize_remote): Add packet configuration for branch tracing. This was already reviewed before and OK for check-in. Thanks, Jan