From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1042 invoked by alias); 4 Mar 2013 15:10:44 -0000 Received: (qmail 955 invoked by uid 22791); 4 Mar 2013 15:10:10 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 04 Mar 2013 15:09:58 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 0E7A1520242; Mon, 4 Mar 2013 16:09:56 +0100 (CET) Date: Mon, 04 Mar 2013 15:10:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash in read_pe_exported_syms Message-ID: <20130304150956.GJ2481@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20130302110216.GA6765@calimero.vinschen.de> <51349AE4.3070200@redhat.com> <20130304143449.GH2481@calimero.vinschen.de> <20130304144132.GA4472@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130304144132.GA4472@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00088.txt.bz2 On Mar 4 09:41, Joel Brobecker wrote: > > I really think that lots of > > > > do_cleanup(); > > return; > > > > blocks are more error prone and less readable than a goto to a defined > > label at the end of a function. Are you really sure you want that? > > Neither is obviously better, IMO, but the general style in GDB so far > has been to call the cleanups before returning... Ok. Applied with that change. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat