From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26040 invoked by alias); 4 Mar 2013 14:41:40 -0000 Received: (qmail 26021 invoked by uid 22791); 4 Mar 2013 14:41:38 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Mar 2013 14:41:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AA6FB2E8A4 for ; Mon, 4 Mar 2013 09:41:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n2iFuoRx-w4q for ; Mon, 4 Mar 2013 09:41:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 92DE62E8A2 for ; Mon, 4 Mar 2013 09:41:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5C153C3E19; Mon, 4 Mar 2013 06:41:32 -0800 (PST) Date: Mon, 04 Mar 2013 14:41:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash in read_pe_exported_syms Message-ID: <20130304144132.GA4472@adacore.com> References: <20130302110216.GA6765@calimero.vinschen.de> <51349AE4.3070200@redhat.com> <20130304143449.GH2481@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130304143449.GH2481@calimero.vinschen.de> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00087.txt.bz2 > I really think that lots of > > do_cleanup(); > return; > > blocks are more error prone and less readable than a goto to a defined > label at the end of a function. Are you really sure you want that? Neither is obviously better, IMO, but the general style in GDB so far has been to call the cleanups before returning... -- Joel