Re: [patch]: Replace stryoul call to fetch address

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Wed, Feb 27, 2013 at 05:20:14PM +0000, Pedro Alves wrote:
>On 02/27/2013 04:44 PM, Corinna Vinschen wrote:
>> Hi,
>
>Hi,
>
>> 
>> here's a small patch which will help along building GDB on the (not
>> yet finished) x86_64 Cygwin.
>> 
>> Mostly these are just a few casts, and tweaks to the printf format
>> strings, so that the argument and the format matches all three cases:
>> 
>> - i686
>> - x86_64 LLP (Mingw, native Windows)
>> - x86_64 LP  (Cygwin)
>> 
>> The most important part of the patch is in handle_output_debug_string,
>> though.  The address for the context information is read from the string
>> using the strtoul function.  This works fine for a 32 bit GDB, and it
>> also works fine for a 64 bit Cygwin GDB.  It does not work for a 64 bit
>> Mingw GDB debugging a 64 bit Cygwin application, though.  Therefore I
>> replaced the strtoul with a call to string_to_core_addr.
>
>IIRC, the matching Cygwin code that that special
>Cygwin signals handling was never implemented, or it was disabled
>on Cygwin, or some such, and that gdb bits is actually causing
>trouble -- see http://sourceware.org/ml/gdb-patches/2013-02/msg00122.html.
>We should just zap it all.

I didn't take from that patch that it was causing problems.

The signal code is expected to work.

cgf