Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx

Jan Kratochvil
2013-02-25T14:19:31Z

On Wed, 20 Feb 2013 21:15:07 +0100, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> > + /* Below we'll mmap a non-executable page, which under Valgrind
> > + results in annoying warnings such as
> > + "Bad permissions for mapped region at address 0xfoobar".
> > + Just skip the whole test if running under Valgrind. */
> > +#ifdef HAVE_RUNNING_ON_VALGRIND
> > + if (RUNNING_ON_VALGRIND)
> > + return;
> > +#endif
>
> Wouldn't it be enough for gdb to ship with an appropriate suppression
> file?

Besides some inconveniences of using suppression files primarily there would
still remain the false warning printed by GDB itself:
warning: linux_ptrace_test_ret_to_nx: PC 0x3806e309 is neither near return address 0x4032000 nor is the return instruction 0x602e33!

Jan