Re: [patch+NEWS] Avoid false valgrind warnings on linux_ptrace_test_ret_to_nx

Andreas Schwab
2013-02-20T20:15:31Z

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> + /* Below we'll mmap a non-executable page, which under Valgrind
> + results in annoying warnings such as
> + "Bad permissions for mapped region at address 0xfoobar".
> + Just skip the whole test if running under Valgrind. */
> +#ifdef HAVE_RUNNING_ON_VALGRIND
> + if (RUNNING_ON_VALGRIND)
> + return;
> +#endif

Wouldn't it be enough for gdb to ship with an appropriate suppression
file?

Andreas.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."